This is an archive of the discontinued LLVM Phabricator instance.

Detect whether the current system is a Linux system
AbandonedPublic

Authored by sconvent on Oct 13 2017, 3:37 AM.

Details

Summary

Detect whether the current system is a Linux system

Diff Detail

Event Timeline

Hahnfeld edited edge metadata.Oct 13 2017, 6:20 AM

GCC has none of these features?! I can't believe that, maybe only some older versions that don't implement OpenMP 4.x?

sconvent updated this revision to Diff 120241.Oct 25 2017, 6:56 AM
sconvent retitled this revision from Detect available features of compiler in lit.cfg to Detect whether the current system is a Linux system.
sconvent edited the summary of this revision. (Show Details)

Only detect whether the current system is a Linux system. Other feature detection is now done in the testcases.

@Hahnfeld You're right, GCC does support some of these features. The GOMP interface implementation of this runtime does not support all of them (yet), however. And for some features, GCC generates code that do not call the runtime, which makes it impossible to call callbacks. The feature detection has been moved to the respective testcases and only the "Linux" feature is detected here.

Reduced like this, I don't think it is necessary to do this in its own revision, especially as there are (currently) no users.

(I was originally only referring to split out INTEL_LICENSE_FILE...)

jlpeyton edited edge metadata.Oct 25 2017, 12:15 PM

Also, if you take the features completely out, D38185 will need updating taking out the features in the REQUIRES: lines in the tests.

sconvent abandoned this revision.Oct 26 2017, 12:52 AM