Page MenuHomePhabricator

[Analyzer] Support bodyfarming std::call_once for libstdc++
ClosedPublic

Authored by george.karpenkov on Oct 11 2017, 11:03 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dcoughlin accepted this revision.Oct 11 2017, 11:24 AM

LGTM with the dyn_cast mentioned inline changed.

lib/Analysis/BodyFarm.cpp
359 ↗(On Diff #118644)

Should this be a cast<>() rather than a dyn_cast<>()? Do you expect this to fail? If so then you should check the result for null. If not then the idiom is to use cast<>().

An alternative would be to change findMemberField() to return a FieldDecl.

This revision is now accepted and ready to land.Oct 11 2017, 11:24 AM
This revision was automatically updated to reflect the committed changes.