This is an archive of the discontinued LLVM Phabricator instance.

[asan] Use full binary path in the Android test runner.
ClosedPublic

Authored by eugenis on Oct 3 2017, 6:01 PM.

Details

Summary

This prevents the confusion when there are similarly named tests in
different configurations (like in test/sanitizer_common).

Event Timeline

eugenis created this revision.Oct 3 2017, 6:01 PM
vitalybuka accepted this revision.Oct 5 2017, 12:42 PM
vitalybuka added inline comments.
compiler-rt/test/sanitizer_common/android_commands/android_common.py
12

Thy this is relative to the / and not to maybe build root?

This revision is now accepted and ready to land.Oct 5 2017, 12:42 PM
eugenis added inline comments.Oct 5 2017, 12:47 PM
compiler-rt/test/sanitizer_common/android_commands/android_common.py
12

This is more reliable, for example, you may run tests from two build trees on one device at the same time. Also, it is easier to implement - otherwise we would need to pass the build root to the script somehow.

This revision was automatically updated to reflect the committed changes.