This is an archive of the discontinued LLVM Phabricator instance.

ISel type legalization: add debug messages. NFC.
ClosedPublic

Authored by SjoerdMeijer on Oct 2 2017, 2:24 AM.

Details

Summary

This adds some debug messages to the type legalizer and functions
like PromoteNode, ExpandNode, ExpandLibCall in an attempt to make
the debug messages a little bit more informative and useful.

Diff Detail

Repository
rL LLVM

Event Timeline

SjoerdMeijer created this revision.Oct 2 2017, 2:24 AM

Added some more.

samparker accepted this revision.Oct 3 2017, 12:26 AM

Hi Sjoerd,

This is some good itch scratching! One comment from me, but no need to re-review. LGTM.

Thanks,
sam

lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
2392 ↗(On Diff #117344)

I think this debug message and the one above would be more helpful contained in their corresponding if statement.

This revision is now accepted and ready to land.Oct 3 2017, 12:26 AM

Hi Sam, many thanks for checking! Cheers, Sjoerd.

This revision was automatically updated to reflect the committed changes.