This is an archive of the discontinued LLVM Phabricator instance.

Fix for the issue 12176 llvm.org/PR12176
Needs ReviewPublic

Authored by maitesin on Sep 28 2017, 1:41 PM.

Details

Reviewers
kristina
Group Reviewers
Restricted Project
Restricted Project
Summary

I have extracted the duplicated function into a header file

Diff Detail

Repository
rL LLVM

Event Timeline

maitesin created this revision.Sep 28 2017, 1:41 PM
vsk added a subscriber: vsk.Sep 28 2017, 4:37 PM
vsk added inline comments.
lib/Sema/DepthAndIndex.h
1

Instead of introducing a new header, have you considered moving this definition into a header all three sites already include?

maitesin added a reviewer: Restricted Project.Sep 29 2017, 6:59 AM

Removed /brief from the doxygen documentation and extracted another function

maitesin added a reviewer: Restricted Project.Oct 1 2017, 8:18 AM

Seeing as there's been no movement to the requested changes, I've taken this over in: https://reviews.llvm.org/D49760

kristina resigned from this revision.Sep 28 2018, 7:42 PM