This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Add CMake support for building for MinGW
ClosedPublic

Authored by mstorsjo on Sep 28 2017, 1:29 PM.

Details

Summary

This is the cmake specific parts of D33601 (by Martell Malone) split out into a separate patch, to ease getting this part reviewed indendent of the rest of that patch.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 28 2017, 1:29 PM
compnerd edited edge metadata.Sep 28 2017, 10:18 PM

With an explanation of the gcc_s vs gcc, I think this LG.

cmake/config-ix.cmake
38

This seems really weird. gcc_s and gcc are the same library, the former is the shared version of the latter. Is this really correct?

mstorsjo added inline comments.Sep 28 2017, 11:05 PM
cmake/config-ix.cmake
38

I think so; my impression is that libgcc.a contains some object files that end up linked into every module, even if you're otherwise using a shared libgcc_s_<ehmode>.dll.

In any case, this is identical to the same lines in libcxxabi and libcxx as well; the only difference is in the library name above in if (<libname>_USE_COMPILER_RT), so if there needs to be a change, it should be changed there as well.

compnerd accepted this revision.Oct 2 2017, 1:42 PM
This revision is now accepted and ready to land.Oct 2 2017, 1:42 PM
This revision was automatically updated to reflect the committed changes.