Assume git-generated patch files in build scripts

[fjricci]

Summary

It is probably reasonable to expect that most (or all) users of
the patch file feature will be using git, and assuming
git patch files makes this feature easier to use.

[fjricci]

@jasonmolenda - just an FYI that I'm an llvm committer (I contribute frequently to compiler-rt, and used to contribute quite a bit to lldb as well). No worries about this patch though, especially given how small it is.

[fjricci]

Oh I see from the discussion on https://github.com/apple/swift-lldb/pull/252 that it was accidental - don't worry about it

scripts/Xcode/build-llvm.py

 
 def apply_patches(spec):
     files = os.listdir(os.path.join(lldb_source_path(), 'scripts'))
     patches = [
         f for f in files if fnmatch.fnmatch(
             f, spec['name'] + '.*.diff')]
     for p in patches:
         run_in_directory(["patch",
-                          "-p0",
+                          "-p1",
                           "-i",
                           os.path.join(lldb_source_path(),
                                        'scripts',
                                        p)],
                          spec['root'])
 
 
 def check_out_if_needed(spec):

scripts/build-lldb-llvm-clang

 cd tools
 svn co -q -r $CLANG_REVISION http://llvm.org/svn/llvm-project/cfe/trunk clang
 
 # change directory to "./llvm"
 cd ..
 for patch_file in ../scripts/llvm.*.diff
 do
   echo "Applying patch from '$patch_file'"
-    patch -p0 < "$patch_file"
+    patch -p1 < "$patch_file"
 done
 
 # change directory to "./llvm/tools/clang"
 cd tools/clang
 for patch_file in ../../../scripts/clang.*.diff
 do
   echo "Applying patch from '$patch_file'"
-    patch -p0 < "$patch_file"
+    patch -p1 < "$patch_file"
 done
 
 # change directory to "./"
 cd ../../..
 pwd
 
 if [ "$LLVM_CONFIGURATION" = "Debug" ]; then
   # Configure "Debug+Asserts" build