Page MenuHomePhabricator

Assume git-generated patch files in build scripts
ClosedPublic

Authored by fjricci on Sep 27 2017, 12:54 PM.

Details

Summary

It is probably reasonable to expect that most (or all) users of
the patch file feature will be using git, and assuming
git patch files makes this feature easier to use.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci created this revision.Sep 27 2017, 12:54 PM
jasonmolenda accepted this revision.Sep 27 2017, 4:44 PM
This revision is now accepted and ready to land.Sep 27 2017, 4:44 PM
This revision was automatically updated to reflect the committed changes.

@jasonmolenda - just an FYI that I'm an llvm committer (I contribute frequently to compiler-rt, and used to contribute quite a bit to lldb as well). No worries about this patch though, especially given how small it is.

Oh I see from the discussion on https://github.com/apple/swift-lldb/pull/252 that it was accidental - don't worry about it