Page MenuHomePhabricator

[opt-viewer] Don't Decode HTML bytes for Python 2
ClosedPublic

Authored by lebedev.ri on Sep 26 2017, 12:13 PM.

Details

Summary

D36624 added some python3 compatibility. But that fix has a problem..

With python2 (which is specified by #!/usr/bin/env python2.7), if the env variables do not specify the UTF8,
and the source file is UTF8 (contains non-ASCII symbols), then the .decode('utf-8') causes the following exception:

Reading YAML files...
Rendering HTML files...
        8 of 41Traceback (most recent call last):
  File "/build/llvm/tools/opt-viewer/opt-viewer.py", line 277, in <module>
    print_progress)
  File "/build/llvm/tools/opt-viewer/opt-viewer.py", line 213, in generate_report
    should_print_progress)
  File "/build/llvm/tools/opt-viewer/optpmap.py", line 45, in pmap
    result = map(_wrapped_func, func_and_args, *args, **kwargs)
  File "/build/llvm/tools/opt-viewer/optpmap.py", line 25, in _wrapped_func
    return func(argument)
  File "/build/llvm/tools/opt-viewer/opt-viewer.py", line 174, in _render_file
    SourceFileRenderer(source_dir, output_dir, filename).render(remarks)
  File "/build/llvm/tools/opt-viewer/opt-viewer.py", line 125, in render
    self.render_source_lines(self.source_stream, line_remarks)
  File "/build/llvm/tools/opt-viewer/opt-viewer.py", line 79, in render_source_lines
    </tr>'''.format(**locals()), file=self.stream)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf4' in position 47: ordinal not in range(128)

This is similar to https://bugs.llvm.org/show_bug.cgi?id=33548, which was fixed by https://reviews.llvm.org/D37661

Unlike that fix, here, *removing* .decode('utf-8') actually fixes it.

Since i assume that the original fix is needed, i simply made
that fix conditional, since for python2 it actually breaks things.

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.Sep 26 2017, 12:13 PM
anemet accepted this revision.Oct 10 2017, 9:00 AM

Sorry about the delay! I remembered something similar also for Python2 so I wanted to doublecheck. Turns out that was https://reviews.llvm.org/D29802 which is unrelated.

LGTM with the additional comment.

@modocache, any opinion about this?

tools/opt-viewer/opt-viewer.py
69 ↗(On Diff #116696)

Please add a comment:

On Python 3, pygments.highlight() returns a bytes object, not
a str.

This revision is now accepted and ready to land.Oct 10 2017, 9:00 AM

Sorry about the delay! I remembered something similar also for Python2 so I wanted to doublecheck. Turns out that was https://reviews.llvm.org/D29802 which is unrelated.

LGTM with the additional comment.

Thank you!

@modocache, any opinion about this?

Since the change is trivial i'll proceed to commit it now.

This revision was automatically updated to reflect the committed changes.

HI @lebedev.ri,

I had to further tweak this in rL320725. Let me know if you see any issues.

Thanks,
Adam