This is an archive of the discontinued LLVM Phabricator instance.

Differential D29802

opt-viewer: fix HtmlFormatter encoding
ClosedPublic

Authored by bcain on Feb 9 2017, 5:29 PM.

Details

Reviewers
anemet
fhahn
Commits
rG386cd3dd6bae: opt-viewer: fix HtmlFormatter encoding
rL294710: opt-viewer: fix HtmlFormatter encoding
Summary

Small fix to HtmlFormatter, defaults to ascii encoding, so utf-8 output may get UnicodeEncodeError: 'ascii' codec can't encode character ... ordinal not in range(128) during write.

Diff Detail

Repository
rL LLVM

Event Timeline

bcain created this revision.Feb 9 2017, 5:29 PM
anemet accepted this revision.Feb 9 2017, 5:30 PM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 9 2017, 5:30 PM
Closed by commit rL294710: opt-viewer: fix HtmlFormatter encoding (authored by anemet). · Explain WhyFeb 9 2017, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
utils/
opt-viewer/
2 lines

Diff 87961

llvm/trunk/utils/opt-viewer/opt-viewer.py

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines def __init__(self, source_dir, output_dir, filename):
else: else:
self.source_stream = None self.source_stream = None
print(''' print('''
<html> <html>
<h1>Unable to locate file {}</h1> <h1>Unable to locate file {}</h1>
</html> </html>
'''.format(filename), file=self.stream) '''.format(filename), file=self.stream)
self.html_formatter = HtmlFormatter() self.html_formatter = HtmlFormatter(encoding='utf-8')
self.cpp_lexer = CppLexer() self.cpp_lexer = CppLexer()
def render_source_line(self, linenum, line): def render_source_line(self, linenum, line):
html_line = highlight(line, self.cpp_lexer, self.html_formatter) html_line = highlight(line, self.cpp_lexer, self.html_formatter)
print(''' print('''
<tr> <tr>
<td><a name=\"L{linenum}\">{linenum}</a></td> <td><a name=\"L{linenum}\">{linenum}</a></td>
<td></td> <td></td>
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines