Details
Diff Detail
- Build Status
Buildable 10472 Build 10472: arc lint + arc unit
Event Timeline
compiler-rt/lib/asan/asan_report.cc | ||
---|---|---|
128–129 | This looks like a data race. halt_on_error_ = fatal; And then the first thread can fail to halt and the program will hang for 100 seconds. Or, there can be 2 thread: one with fatal=true and another with fatal=false, and asan will halt after a non-fatal error which can cause user confusion. | |
129–130 | This looks somewhat fishy. Is there any known problem with making this an infinite loop as it is now? |
compiler-rt/lib/asan/asan_report.cc | ||
---|---|---|
128–129 |
Not sure I understand you.
Correct. I noticed that this is weird too, but I believe it's preexisted behavior and not related to the bug I am fixing. So I was not trying to improve that. | |
129–130 | Probably nothing known. |
compiler-rt/lib/asan/asan_report.cc | ||
---|---|---|
128–129 | Right. It's not static. Withdrawn. |
compiler-rt/lib/asan/asan_report.cc | ||
---|---|---|
129–130 | What if GetCurrentTidOrInvalid return kInvalidTid? We will start reporting w/o claiming reporting_thread_tid_. Use a different default value? |
compiler-rt/lib/asan/asan_report.cc | ||
---|---|---|
125 | 0xfffffe |
0xfffffe