Differential D37916

[WebAssembly] MC: Fix crash in getProvitionalValue on weak references
ClosedPublic
Actions

Authored by sbc100 on Sep 15 2017, 12:08 PM.

Details

Reviewers

jgravelle-google

Commits

rGaff1c4df2573: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references
rL313381: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references

Summary

Create helper function for resolving weak references.
Add test that preproduces the crash.

Diff Detail

Repository: rL LLVM

Event Timeline

sbc100 created this revision.Sep 15 2017, 12:08 PM

Herald added subscribers: aheejin, jgravelle-google, dschuff, jfb. · View Herald TranscriptSep 15 2017, 12:08 PM

Harbormaster completed remote builds in B10297: Diff 115449.Sep 15 2017, 12:08 PM

fix test

Harbormaster completed remote builds in B10298: Diff 115450.Sep 15 2017, 12:09 PM

sbc100 added a reviewer: jgravelle-google.Sep 15 2017, 12:09 PM

sbc100 added a subscriber: llvm-commits.

Looks good to me (take that with a grain of salt, but this seems straightforward?)

This revision is now accepted and ready to land.Sep 15 2017, 12:11 PM

Closed by commit rL313381: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references (authored by sbc). · Explain WhySep 15 2017, 12:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

MC/

WasmObjectWriter.cpp

30 lines

test/

MC/

WebAssembly/

46 lines

Diff 115456

llvm/trunk/lib/MC/WasmObjectWriter.cpp

Loading...

llvm/trunk/test/MC/WebAssembly/weak-alias.ll

Loading...