Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Paths
Table of Contents
t
Hide Panel
f
Keyboard Reference
?
Differential
D37916
[WebAssembly] MC: Fix crash in getProvitionalValue on weak references
Closed
Public
Actions
Authored by
sbc100
on Sep 15 2017, 12:08 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
None
Subscribers
aheejin
dschuff
jfb
jgravelle-google
llvm-commits
Details
Reviewers
jgravelle-google
Commits
rGaff1c4df2573: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references
rL313381: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references
Summary
Create helper function for resolving weak references.
Add test that preproduces the crash.
Diff Detail
Repository
rL LLVM
Event Timeline
sbc100
created this revision.
Sep 15 2017, 12:08 PM
Herald
added subscribers:
aheejin
,
jgravelle-google
,
dschuff
,
jfb
.
·
View Herald Transcript
Sep 15 2017, 12:08 PM
Harbormaster
completed remote builds in
B10297: Diff 115449
.
Sep 15 2017, 12:08 PM
sbc100
updated this revision to
Diff 115450
.
Sep 15 2017, 12:09 PM
Comment Actions
fix test
Harbormaster
completed remote builds in
B10298: Diff 115450
.
Sep 15 2017, 12:09 PM
sbc100
added a reviewer:
jgravelle-google
.
Sep 15 2017, 12:09 PM
sbc100
added a subscriber:
llvm-commits
.
jgravelle-google
accepted this revision.
Sep 15 2017, 12:11 PM
Comment Actions
Looks good to me (take that with a grain of salt, but this seems straightforward?)
This revision is now accepted and ready to land.
Sep 15 2017, 12:11 PM
Closed by commit
rL313381: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references
(authored by sbc).
·
Explain Why
Sep 15 2017, 12:23 PM
This revision was automatically updated to reflect the committed changes.