This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Move stack overflow and signal reporting from Asan into common.
ClosedPublic

Authored by vitalybuka on Sep 14 2017, 12:57 AM.

Event Timeline

vitalybuka created this revision.Sep 14 2017, 12:57 AM
eugenis added inline comments.Sep 14 2017, 1:24 PM
compiler-rt/lib/asan/asan_errors.cc
31

Why do we need ErrorStackOverflow class if the caller is going to re-test for the stack-overflow condition?

vitalybuka marked an inline comment as done.Sep 14 2017, 1:30 PM
vitalybuka added inline comments.
compiler-rt/lib/asan/asan_errors.cc
31

Probably we don't. I have unfinished patch to merge them.
As check is not expensive I'd prefer to do it afterwards

vitalybuka marked 2 inline comments as done.

rebase on D37868

compiler-rt/lib/asan/asan_errors.cc
31
alekseyshl accepted this revision.Sep 14 2017, 3:33 PM
This revision is now accepted and ready to land.Sep 14 2017, 3:33 PM
This revision was automatically updated to reflect the committed changes.