This is an archive of the discontinued LLVM Phabricator instance.

llvm-dwarfdump: Make -brief the default and add -verbose instead.
ClosedPublic

Authored by aprantl on Sep 11 2017, 3:44 PM.

Details

Summary

This patch reverses the defaults and make --brief the default behavior for llvm-dwarfdump and instead introduces a --verbose option. This is matches the behavior of Darwin dwarfdump and is also generally a more sensible default for human users who often don't care about details like abbreviations or forms.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.Sep 11 2017, 3:44 PM
dblaikie accepted this revision.Sep 11 2017, 3:50 PM

Seems good to me

This revision is now accepted and ready to land.Sep 11 2017, 3:50 PM
This revision was automatically updated to reflect the committed changes.
rnk added inline comments.Sep 11 2017, 4:31 PM
llvm/trunk/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
85

Think we should push this rename through the tool?

JDevlieghere added inline comments.
llvm/trunk/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
85

+1

Since it was so little work I just went ahead: https://reviews.llvm.org/D37745