This is an archive of the discontinued LLVM Phabricator instance.

Differential D37658

[ubsan] Save binary name before parsing options
ClosedPublic

Authored by vitalybuka on Sep 9 2017, 12:11 AM.

Details

Reviewers
eugenis
alekseyshl
Commits
rGbdcc82d7eda1: [ubsan] Save binary name before parsing options
rG57ff31436886: [ubsan] Save binary name before parsing options
rCRT312953: [ubsan] Save binary name before parsing options
rCRT312933: [ubsan] Save binary name before parsing options
rL312953: [ubsan] Save binary name before parsing options
rL312933: [ubsan] Save binary name before parsing options
Summary

To parser "include" we may need to do binary name substitution.

Diff Detail

Event Timeline

vitalybuka created this revision.Sep 9 2017, 12:11 AM
Herald added a subscriber: kubamracek. · View Herald TranscriptSep 9 2017, 12:11 AM
Harbormaster completed remote builds in B10054: Diff 114476.Sep 9 2017, 12:11 AM
eugenis accepted this revision.Sep 11 2017, 10:53 AM
This revision is now accepted and ready to land.Sep 11 2017, 10:53 AM
Closed by commit rL312933: [ubsan] Save binary name before parsing options (authored by vitalybuka). · Explain WhySep 11 2017, 11:34 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka reopened this revision.Sep 11 2017, 2:11 PM
This revision is now accepted and ready to land.Sep 11 2017, 2:11 PM
vitalybuka updated this revision to Diff 114692.Sep 11 2017, 2:12 PM

Correct rebase.

Harbormaster completed remote builds in B10102: Diff 114692.Sep 11 2017, 2:12 PM
Closed by commit rL312953: [ubsan] Save binary name before parsing options (authored by vitalybuka). · Explain WhySep 11 2017, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
lib/
ubsan/
2 lines
test/
sanitizer_common/
TestCases/
1 line

Diff 114692

compiler-rt/lib/ubsan/ubsan_init.cc

Show All 34 Lines
static StaticSpinMutex ubsan_init_mu; static StaticSpinMutex ubsan_init_mu;
static void CommonInit() { static void CommonInit() {
InitializeSuppressions(); InitializeSuppressions();
} }
static void CommonStandaloneInit() { static void CommonStandaloneInit() {
SanitizerToolName = GetSanititizerToolName(); SanitizerToolName = GetSanititizerToolName();
InitializeFlags();
CacheBinaryName(); CacheBinaryName();
InitializeFlags();
__sanitizer_set_report_path(common_flags()->log_path); __sanitizer_set_report_path(common_flags()->log_path);
AndroidLogInit(); AndroidLogInit();
InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir); InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir);
CommonInit(); CommonInit();
ubsan_mode = UBSAN_MODE_STANDALONE; ubsan_mode = UBSAN_MODE_STANDALONE;
} }
void __ubsan::InitAsStandalone() { void __ubsan::InitAsStandalone() {
Show All 31 Lines

compiler-rt/test/sanitizer_common/TestCases/options-include.cc

// RUN: %clangxx -O0 %s -o %t // RUN: %clangxx -O0 %s -o %t
// UNSUPPORTED: ubsan
// Recursive include: options1 includes options2 // Recursive include: options1 includes options2
// RUN: echo "symbolize=1" > %t.options1.txt // RUN: echo "symbolize=1" > %t.options1.txt
// RUN: echo "include='%t.options2.txt'" >>%t.options1.txt // RUN: echo "include='%t.options2.txt'" >>%t.options1.txt
// RUN: echo "help=1" >%t.options2.txt // RUN: echo "help=1" >%t.options2.txt
// RUN: echo "help=1" >%t.options.options-include.cc.tmp // RUN: echo "help=1" >%t.options.options-include.cc.tmp
// RUN: cat %t.options1.txt // RUN: cat %t.options1.txt
// RUN: cat %t.options2.txt // RUN: cat %t.options2.txt
Show All 38 Lines