This is an archive of the discontinued LLVM Phabricator instance.

run-clang-tidy: Use check_call instead of check_output
ClosedPublic

Authored by kfunk on Sep 5 2017, 8:24 AM.

Reviewers

cfe-commits
alexfh

Commits

Summary

Streamlines the output under Python 3.x.

Before:

b'Enabled checks:\n    clang-analyzer-apiModeling.google.GTest\n ...

After:

Enabled checks:
    clang-analyzer-apiModeling.google.GTest
...

Build Status

Buildable 9903
Build 9903: arc lint + arc unit

Bump? This is a trivial one

LG, if this still works under Python 2.

This revision is now accepted and ready to land.Nov 27 2017, 4:44 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang-tidy/

tool/

2 lines

Show First 20 Lines • Show All 210 Lines • ▼ Show 20 Lines	else:
build_path = find_compilation_database(db_path)		build_path = find_compilation_database(db_path)

try:		try:
invocation = [args.clang_tidy_binary, '-list-checks']		invocation = [args.clang_tidy_binary, '-list-checks']
invocation.append('-p=' + build_path)		invocation.append('-p=' + build_path)
if args.checks:		if args.checks:
invocation.append('-checks=' + args.checks)		invocation.append('-checks=' + args.checks)
invocation.append('-')		invocation.append('-')
print(subprocess.check_output(invocation))		subprocess.check_call(invocation)
except:		except:
print("Unable to run clang-tidy.", file=sys.stderr)		print("Unable to run clang-tidy.", file=sys.stderr)
sys.exit(1)		sys.exit(1)

# Load the database and extract all files.		# Load the database and extract all files.
database = json.load(open(os.path.join(build_path, db_path)))		database = json.load(open(os.path.join(build_path, db_path)))
files = [entry['file'] for entry in database]		files = [entry['file'] for entry in database]

▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines