Don't show deleted function (constructor) candidates for code completion

[yvvan]

Summary

In case of copy constructor is implicitly deleted it's still shown

https://bugs.llvm.org/show_bug.cgi?id=34402 describes a way to reproduce that

[yvvan]

Move the change to the SemaCodeComplete - it should not affect diagnostics

[bkramer]

test/Index/complete-constructor-params.cpp

157

This doesn't test anything, FileCheck returns 1 if it doesn't have any input so the test always passes. I'd prefer to rewrite this with CHECK-CC11-NOT instead of negating the FileCheck invocation,

[yvvan]

Fix test

[bkramer]

lgtm

lib/Sema/SemaCodeComplete.cpp

if (!CandidateSet.empty()) {
     // Sort the overload candidate set by placing the best overloads first.
     std::stable_sort(
         CandidateSet.begin(), CandidateSet.end(),
         [&](const OverloadCandidate &X, const OverloadCandidate &Y) {
           return isBetterOverloadCandidate(SemaRef, X, Y, Loc);
         });
 
     // Add the remaining viable overload candidates as code-completion results.
-    for (auto &Candidate : CandidateSet)
+    for (auto &Candidate : CandidateSet) {
+      if (Candidate.Function && Candidate.Function->isDeleted())
+        continue;
       if (Candidate.Viable)
         Results.push_back(ResultCandidate(Candidate.Function));
     }
   }
+}
 
 /// \brief Get the type of the Nth parameter from a given set of overload
 /// candidates.
 static QualType getParamType(Sema &SemaRef,
                              ArrayRef<ResultCandidate> Candidates,
                              unsigned N) {
 
   // Given the overloads 'Candidates' for a function call matching all arguments

test/Index/complete-constructor-params.cpp

int main() {
   S<int> s(42, 42, 42);
 
   S<int>(42, 42, 42,);
   S<int> z(42, 42, 42,);
 
   int(42);
 }
 
+struct Foo {
+    Foo() = default;
+    Foo(const Foo&) = delete;
+};
+
+struct Bar {
+    Foo f;
+};
+
+void function() {
+    Bar b1;
+    Bar b2(b1);
+}
+
 // RUN: c-index-test -code-completion-at=%s:11:10 %s | FileCheck -check-prefix=CHECK-CC1 %s
 // CHECK-CC1: OverloadCandidate:{Text S}{LeftParen (}{CurrentParameter const S<int> &}{RightParen )} (1)
 // CHECK-CC1: OverloadCandidate:{Text S}{LeftParen (}{CurrentParameter int}{Comma , }{Placeholder U}{Comma , }{Placeholder U}{RightParen )} (1)
 // CHECK-CC1: Completion contexts:
 // CHECK-CC1-NEXT: Any type
 // CHECK-CC1-NEXT: Any value
 // CHECK-CC1-NEXT: Enum tag
 // CHECK-CC1-NEXT: Union tag

 // CHECK-CC10-NEXT: Any type
 // CHECK-CC10-NEXT: Any value
 // CHECK-CC10-NEXT: Enum tag
 // CHECK-CC10-NEXT: Union tag
 // CHECK-CC10-NEXT: Struct tag
 // CHECK-CC10-NEXT: Class name
 // CHECK-CC10-NEXT: Nested name specifier
 // CHECK-CC10-NEXT: Objective-C interface
+
+// RUN: c-index-test -code-completion-at=%s:32:12 %s | FileCheck -check-prefix=CHECK-CC11 %s
+// CHECK-CC11-NOT: OverloadCandidate:{Text Bar}{LeftParen (}{CurrentParameter const Bar &}{RightParen )} (1)