Page MenuHomePhabricator

Don't show deleted function (constructor) candidates for code completion
ClosedPublic

Authored by yvvan on Sep 4 2017, 2:54 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

yvvan created this revision.Sep 4 2017, 2:54 AM
yvvan updated this revision to Diff 113741.Sep 4 2017, 5:35 AM
yvvan retitled this revision from Don't show deleted copy constructors in constructor code completions to Don't show deleted function (constructor) candidates for code completion.
yvvan added reviewers: bkramer, klimek, arphaman.

Move the change to the SemaCodeComplete - it should not affect diagnostics

bkramer added inline comments.Sep 4 2017, 7:10 AM
test/Index/complete-constructor-params.cpp
157 ↗(On Diff #113741)

This doesn't test anything, FileCheck returns 1 if it doesn't have any input so the test always passes. I'd prefer to rewrite this with CHECK-CC11-NOT instead of negating the FileCheck invocation,

yvvan updated this revision to Diff 113752.Sep 4 2017, 7:34 AM
yvvan marked an inline comment as done.

Fix test

bkramer accepted this revision.Sep 4 2017, 7:56 AM

lgtm

This revision is now accepted and ready to land.Sep 4 2017, 7:56 AM
This revision was automatically updated to reflect the committed changes.