Details
Diff Detail
Event Timeline
lib/Target/AMDGPU/SIInstructions.td | ||
---|---|---|
1289 | This won't work. For now it's probably easier to just throw an S_MOV_B32 of the constant. This won't encode correctly as a direct immediate because you need to manipulate op_sel |
lib/Target/AMDGPU/SIInstructions.td | ||
---|---|---|
1289 | It was here before, this is the old code and the fix does not belong to the current change. |
lib/Target/AMDGPU/SIInstructions.td | ||
---|---|---|
1289 | For some reason S_MOV_B32 does not work here. It is really a separate issue and has to be addressed separately. |
lib/Target/AMDGPU/SIInstructions.td | ||
---|---|---|
1289 | Why doesn't it work? What about V_MOV_B32? The constant needs to be materialized in some way. Actually I think setting this to be FP16 zero is fine, as long as you remove the SRCMODS.OP_SEL_1 from it. |
lib/Target/AMDGPU/SIInstructions.td | ||
---|---|---|
1289 | As I said this is really a subject for the separate patch. |
lib/Target/AMDGPU/SIInstructions.td | ||
---|---|---|
1289 | It's not, because what is here is incorrect and will not work. |
This won't work. For now it's probably easier to just throw an S_MOV_B32 of the constant. This won't encode correctly as a direct immediate because you need to manipulate op_sel