This is an archive of the discontinued LLVM Phabricator instance.

Enable GetRandom for Fuchsia sanitizer.
ClosedPublic

Authored by flowerhack on Aug 28 2017, 9:28 AM.

Reviewers

Commits

Summary

Adds a true implementation of GetRandom, to be used by scudo_utils.h.

mcgrathr requested changes to this revision.Aug 28 2017, 12:16 PM

mcgrathr added inline comments.

lib/sanitizer_common/sanitizer_fuchsia.cc
487	Smacks of untestedness! sizeof(buffer) should be length.

This revision now requires changes to proceed.Aug 28 2017, 12:16 PM

Fixes from mcgrathr@ feedback.

flowerhack marked an inline comment as done.Aug 28 2017, 12:41 PM

LGTM

This revision is now accepted and ready to land.Aug 28 2017, 1:04 PM

Path

Size

lib/

sanitizer_common/

8 lines

	Show First 20 Lines • Show All 474 Lines • ▼ Show 20 Lines
	}			}

	uptr ReadLongProcessName(/out/ char *buf, uptr buf_len) {			uptr ReadLongProcessName(/out/ char *buf, uptr buf_len) {
	return ReadBinaryName(buf, buf_len);			return ReadBinaryName(buf, buf_len);
	}			}

	uptr MainThreadStackBase, MainThreadStackSize;			uptr MainThreadStackBase, MainThreadStackSize;

				bool GetRandom(void *buffer, uptr length, bool blocking) {
				CHECK_LE(length, MX_CPRNG_DRAW_MAX_LEN);
				size_t size;
				CHECK_EQ(_mx_cprng_draw(buffer, length, &size), MX_OK);
				CHECK_EQ(size, length);
				mcgrathrUnsubmitted Done Reply Inline Actions Smacks of untestedness! sizeof(buffer) should be length. mcgrathr: Smacks of untestedness! sizeof(buffer) should be length.
				return true;
				}

	} // namespace __sanitizer			} // namespace __sanitizer

	using namespace __sanitizer; // NOLINT			using namespace __sanitizer; // NOLINT

	extern "C" {			extern "C" {
	void __sanitizer_startup_hook(int argc, char argv, char envp,			void __sanitizer_startup_hook(int argc, char argv, char envp,
	void *stack_base, size_t stack_size) {			void *stack_base, size_t stack_size) {
	__sanitizer::StoredArgv = argv;			__sanitizer::StoredArgv = argv;
	Show All 17 Lines