This is an archive of the discontinued LLVM Phabricator instance.

Change Diagnostic Category size error from runtime to compiletime
ClosedPublic

Authored by erichkeane on Aug 24 2017, 3:32 PM.

Diff Detail

Event Timeline

erichkeane created this revision.Aug 24 2017, 3:32 PM

Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm going to try to figure that out....

rnk edited edge metadata.Aug 24 2017, 3:44 PM

Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm going to try to figure that out....

Yeah, I'm seeing issues with that as well. I'm not sure what's up.

In D37122#852018, @rnk wrote:

Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm going to try to figure that out....

Yeah, I'm seeing issues with that as well. I'm not sure what's up.

I'm trying to research it... Some people (Stephen Hines & I) are having this issue with the git mirror, but others (CraigT) are not for some reason. There is a cfe-dev discussion started by Stephen, but I've really got no idea whats wrong.

Removed file due to git weirdness.

rnk added inline comments.Aug 28 2017, 10:35 AM
include/clang/Basic/AllDiagnostics.h
37

I'd prefer it if we sank this into a .cpp file so that when it fails, it doesn't create a waterfall of colorful static_assert errors. :)

erichkeane marked an inline comment as done.

Moved static assert into a .cpp file, DiagnosticIDs.cpp seems like the one that makes the most sense.

rnk accepted this revision.Aug 28 2017, 11:51 AM

lgtm

This revision is now accepted and ready to land.Aug 28 2017, 11:51 AM
This revision was automatically updated to reflect the committed changes.