- The LoopUnrolling feature needs the LoopExit included in the CFG so added this dependency via the config options
- The LoopExit element can be encountered even if we haven't encountered the block of the corresponding LoopStmt. So the asserts were not right.
- If we are caching out the Node then we get a nullptr from generateNode which case was not handled.
|190 ↗||(On Diff #112713)|
I would rather keep this method as is and add the extra logic elsewhere (ex: the place where includeLoopExitInCFG is used). To me, AnalyzerOptions::includeLoopExitInCFG() returns the value of the corresponding parameter and I would not expect it to use anything else.
|276 ↗||(On Diff #112713)|
nit: "loop" "exit" and "loop" "stack" are separate words, so consider using "_" to separate them.