Page MenuHomePhabricator

[clang-diff] Refactor stop-after command-line flag
ClosedPublic

Authored by jgravelle-google on Aug 21 2017, 4:04 PM.

Details

Summary

Rename stop-after to stop-after-topdown. When building LLVM with
-DLLVM_BUILD_LLVM_DYLIB=ON, stop-after collides with the stop-after
already present in LLVM.

This also refactors the flag to a boolean, to reflect that it can only
be in two states.

Diff Detail

Repository
rL LLVM

Event Timeline

johannes accepted this revision.Aug 22 2017, 1:40 AM

Looks good, thanks!
You can remove StopAfterTopDown from the ComparisonOptions struct definition

I have a second option stop-after option coming up but I will use another boolean for it, it is simpler this way.

This revision is now accepted and ready to land.Aug 22 2017, 1:40 AM
johannes requested changes to this revision.Aug 22 2017, 1:49 AM

Oh wait I get linker errors with BUILD_SHARED_LIBS=1

undefined reference to ClangDiffCategory in ASTDiff

This revision now requires changes to proceed.Aug 22 2017, 1:49 AM

If you have more stop-after options it'd probably be simpler to leave it as one field. I'll just rename it to "stop-diff-after" to avoid the name collision.

jgravelle-google edited edge metadata.
  • Undo refactor, just change name

If you have more stop-after options it'd probably be simpler to leave it as one field. I'll just rename it to "stop-diff-after" to avoid the name collision.

Ok, you can go ahead. Or, if I should do it let me know.

This revision was automatically updated to reflect the committed changes.