User Details
- User Since
- Mar 31 2017, 3:22 AM (280 w, 3 d)
Jun 10 2022
No idea why the conversion fails for the wide string.
First step is to reproduce the problem. I guess we should try in a Ubuntu VM.
Is there an easy way to see if other builders succeeded?
Jun 7 2022
Ok thanks, I will take a look later. Might be a locale issue
Jun 6 2022
I've suggested some more refactorings but otherwise this should be good to go
May 31 2022
I wonder if clang-diff is useful in its current state, I remember there are many edge cases left over.
Dec 20 2019
I'm having some troubles fixing this build failure:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1866/
Dec 19 2019
check if the function's section is executable
- Use addr.IsSectionOffset() as suggested.
- Add test that links two copies of a compilation unit and makes sure that lldb only resolves it once.
Dec 16 2019
Thanks for the very useful feedback! Now I can finally see why this is happening.
different approach (WIP): ignore functions with DW_AT_low_pc = 0
Dec 13 2019
typo
Dec 3 2019
update comment and commit message
Dec 2 2019
duplicate of https://reviews.llvm.org/D70894
Nov 30 2019
Nov 27 2019
Committed as 1ac700cdef787383ad49a0e37d9894491ef19480 - this should be a safe fix
update commit message
Nov 15 2019
Remove unnecessary const on parameter
Aug 27 2018
Apr 14 2018
Dec 27 2017
use generic concat
Dec 20 2017
Dec 18 2017
I use a different approach now, WDYT?
remove codeconcat, make strconcat return code if all arguments are
Dec 12 2017
add documentation + test
Dec 4 2017
So you can define a category for cHash and add let cHash = [{ .. }] or let cHash = TypeIIClone; if you just want to reuse it.
With this patch you can also use !codeconcat to append some code: https://reviews.llvm.org/D40782
adhere to the column limit
I think it would be quite nice if we manage to consolidate the implementation of hashing mechanisms.
Nov 5 2017
update
update
use raw source code of owned tokens instead
update
Sep 13 2017
use CXXOperatorCallExpr::isPrefixOp() to determine whether it's infix or postfix
directly traverse statement children instead of copying
Sep 11 2017
Sep 9 2017
Sep 6 2017
@teemperor ok for you? did phabricator make you a blocking reviewer because of the affected code, or did I do that somehow?
Sep 1 2017
undo visibility change
fix by adding an option in RecursiveASTVisitor
Aug 29 2017
fixes
This is currently broken, if a user provides a TraverseClassTemplateDecl, then the same method in this class will not be called, I think I will add a flag (probably not user visible) in RecursiveASTVisitor.h to switch the order for templates
Aug 28 2017
Yeah, this seems to be the best solution for this. I think I ran into the same issue when working on the StmtDataCollector - basically there can only be two Traverse*, one in the Derived class and the other one needs to do all the magic with walking the specialisation hierarchy.
use a specialized getStmtChildren to fix the order for CXXOperatorCallExpr
split to ASTDiff/ASTPatch
detect prefix/postfix from number of arguments
The previous version didn't call TraverseDecl of the derived class, this is fixed now.
The public getDerived.TraverseStmt() does not accept a DataRecursionQueue, so this also could not be used (I think)
I used the wrapper TraverseStmtBase, which should behave exactly as the method that originally traverses CXXOperatorCallExpr
do call derived TraverseStmt for children of CXXOperatorCallExpr
use RecursiveASTVisitor::TraverseStmt