Page MenuHomePhabricator

[TSan] Update test values
ClosedPublic

Authored by vlad.tsyrklevich on Aug 18 2017, 11:44 AM.

Details

Summary

This test was broken by the tail duplication logic being changed in
r311139, update the test values and add a note about how to properly run
a benchmark to verify that the values are safe to update.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka accepted this revision.Aug 18 2017, 12:20 PM
vitalybuka added a subscriber: dvyukov.
This revision is now accepted and ready to land.Aug 18 2017, 12:20 PM
This revision was automatically updated to reflect the committed changes.
kcc added a subscriber: kcc.

This sucks. If we have so many pops in the hot function, the test essentially becomes useless.
Does this function really need to many pops? Isn't it a pessimization?

The increase in pops is because of function epilogue duplication, a single execution of the function should still see the same number of pops. That said, it is significantly less useful to be tracking the total number of pops rather than accounting for the control-flow somehow.