Simplify registerMatchers and check functions in CloexecCreatCheck,
CloexecSocketCheck, CloexecFopenCheck, and CloexecOpenCheck.
Details
Details
- Reviewers
alexfh hokein Eugene.Zelenko - Commits
- rG2414429962a6: [clang-tidy] Remove unused static variable.
rGa54d37981262: [clang-tidy] Use const char* to compile with VC cl.exe.
rGfec506daaa4f: [clang-tidy] Use CloexecCheck as base class.
rCTE311035: [clang-tidy] Use const char* to compile with VC cl.exe.
rCTE311040: [clang-tidy] Remove unused static variable.
rCTE311020: [clang-tidy] Use CloexecCheck as base class.
rL311040: [clang-tidy] Remove unused static variable.
rL311035: [clang-tidy] Use const char* to compile with VC cl.exe.
rL311020: [clang-tidy] Use CloexecCheck as base class.
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM with a few nits.
clang-tidy/android/CloexecCheck.h | ||
---|---|---|
95 ↗ | (On Diff #111243) | nit: use static constexpr char FuncDeclBindingStr[] ="...", the same below. |
clang-tidy/android/CloexecFopenCheck.cpp | ||
31 | nit: add /*Mode=*/'e', /*ArgsPos=*/1, the same to other places. | |
clang-tidy/android/CloexecOpenCheck.cpp | ||
37 ↗ | (On Diff #111243) | Should we check or assert FD->param_size() > 0? |
nit: add /*Mode=*/'e', /*ArgsPos=*/1, the same to other places.