Page MenuHomePhabricator

[clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.
AbandonedPublic

Authored by chh on Aug 15 2017, 11:06 AM.

Details

Reviewers
alexfh
hokein
Summary

Simplify registerMatchers and check functions in CloexecFopenCheck.

Diff Detail

Event Timeline

chh created this revision.Aug 15 2017, 11:06 AM

I think you could combine this refactoring into single change.

chh added a comment.Aug 15 2017, 11:30 AM

Eugene, do you mean combining this one, D36756, and D36755 into one?
I don't mind either way.

In D36759#842367, @chh wrote:

Eugene, do you mean combining this one, D36756, and D36755 into one?
I don't mind either way.

Sure. All three diffs are of same kind.

chh added a comment.Aug 15 2017, 11:45 AM

Okay, 3 changes are combined into D36761.

Please abandon this and other similar revisions as obsoleted by D36761.

chh abandoned this revision.Aug 15 2017, 1:32 PM

Included in D36761.