Page MenuHomePhabricator

[clang-tidy] Use CloexecCheck as base class.
ClosedPublic

Authored by chh on Aug 15 2017, 11:44 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

chh updated this revision to Diff 111243.Aug 15 2017, 1:42 PM
chh edited the summary of this revision. (Show Details)
hokein accepted this revision.Aug 16 2017, 3:13 AM

LGTM with a few nits.

clang-tidy/android/CloexecCheck.h
95 ↗(On Diff #111243)

nit: use static constexpr char FuncDeclBindingStr[] ="...", the same below.

clang-tidy/android/CloexecFopenCheck.cpp
31 ↗(On Diff #111243)

nit: add /*Mode=*/'e', /*ArgsPos=*/1, the same to other places.

clang-tidy/android/CloexecOpenCheck.cpp
37 ↗(On Diff #111243)

Should we check or assert FD->param_size() > 0?

This revision is now accepted and ready to land.Aug 16 2017, 3:13 AM
chh updated this revision to Diff 111372.Aug 16 2017, 9:57 AM
chh marked 3 inline comments as done.
This revision was automatically updated to reflect the committed changes.