Fix VASprintfTest.cpp for Darwin, add checks

[penryu]

Summary

The EncodingError test ensures that trying to encode a multibyte wchar
with a given codepage fails. If setlocale() fails, the encoding is
performed using the current locale, which may or may not fail.

This patch asserts that both setlocale() operations are successful, as
well as falling back to a widely available unibyte encoding for
non-Windows systems.

rdar://problem/33782806

[penryu]

I'd prototyped this as simply prepending "DISABLED_" for non-Windows, but as this was designed as a temporary measure, I decided to ensure the same behavior was tested on Windows, and similar/equivalent behavior tested on other platforms.

[penryu]

Committed revision 310499.
Closing revision D36496 'Fix VASprintfTest.cpp for Darwin, add checks'...

lldb.xcodeproj/project.pbxproj

/* Begin PBXBuildFile section */
     9694FA711B32AA64005EBB16 /* ABISysV_mips.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9694FA6F1B32AA64005EBB16 /* ABISysV_mips.cpp */; };
     9A0FDEA71E8EF5110086B2F5 /* RegisterContextLinux_mips.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A0FDE971E8EF5010086B2F5 /* RegisterContextLinux_mips.cpp */; };
     9A1542F91F0EE48600DEA1D8 /* MockTildeExpressionResolver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A1542F51F0EE44000DEA1D8 /* MockTildeExpressionResolver.cpp */; };
     9A1542FA1F0EE48600DEA1D8 /* TestUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A1542F71F0EE44000DEA1D8 /* TestUtilities.cpp */; };
     9A19A6AF1163BBB200E0D453 /* SBValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 9A19A6A51163BB7E00E0D453 /* SBValue.h */; settings = {ATTRIBUTES = (Public, ); }; };
     9A19A6B01163BBB300E0D453 /* SBValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A19A6AD1163BB9800E0D453 /* SBValue.cpp */; };
     9A1E595C1EB2B141002206A5 /* SBTrace.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */; };
     9A1E595D1EB2B141002206A5 /* SBTraceOptions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A1E59531EB2B0B9002206A5 /* SBTraceOptions.cpp */; };
+    9A2057031F3A605200F6C293 /* VASprintfTest.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A3D43C41F3150D200EB767C /* VASprintfTest.cpp */; };
     9A22A161135E30370024DDC3 /* EmulateInstructionARM.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A22A15D135E30370024DDC3 /* EmulateInstructionARM.cpp */; };
     9A22A163135E30370024DDC3 /* EmulationStateARM.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A22A15F135E30370024DDC3 /* EmulationStateARM.cpp */; };
     9A357583116CFDEE00E8ED2F /* SBValueList.h in Headers */ = {isa = PBXBuildFile; fileRef = 9A357582116CFDEE00E8ED2F /* SBValueList.h */; settings = {ATTRIBUTES = (Public, ); }; };
     9A35758E116CFE0F00E8ED2F /* SBValueList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A35758D116CFE0F00E8ED2F /* SBValueList.cpp */; };
     9A357671116E7B5200E8ED2F /* SBStringList.h in Headers */ = {isa = PBXBuildFile; fileRef = 9A357670116E7B5200E8ED2F /* SBStringList.h */; settings = {ATTRIBUTES = (Public, ); }; };
     9A357673116E7B6400E8ED2F /* SBStringList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A357672116E7B6400E8ED2F /* SBStringList.cpp */; };
     9A3576A8116E9AB700E8ED2F /* SBHostOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 9A3576A7116E9AB700E8ED2F /* SBHostOS.h */; settings = {ATTRIBUTES = (Public, ); }; };
     9A3576AA116E9AC700E8ED2F /* SBHostOS.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9A3576A9116E9AC700E8ED2F /* SBHostOS.cpp */; };
23CB15321D66DA9300EDDDE1 /* Sources */ = {
         9A1542FA1F0EE48600DEA1D8 /* TestUtilities.cpp in Sources */,
         9A3D43EC1F3237F900EB767C /* ListenerTest.cpp in Sources */,
         9A3D43DC1F3151C400EB767C /* TimeoutTest.cpp in Sources */,
         9A3D43D61F3151C400EB767C /* ConstStringTest.cpp in Sources */,
         23CB153F1D66DA9300EDDDE1 /* SymbolsTest.cpp in Sources */,
         AFEC5FD81D94F9380076A480 /* Testx86AssemblyInspectionEngine.cpp in Sources */,
         23CB15401D66DA9300EDDDE1 /* TestClangASTContext.cpp in Sources */,
         23CB15411D66DA9300EDDDE1 /* StringExtractorTest.cpp in Sources */,
+        9A2057031F3A605200F6C293 /* VASprintfTest.cpp in Sources */,
         23CB15421D66DA9300EDDDE1 /* TaskPoolTest.cpp in Sources */,
         23CB15431D66DA9300EDDDE1 /* BroadcasterTest.cpp in Sources */,
         9A3D43EE1F3237F900EB767C /* StreamCallbackTest.cpp in Sources */,
         23CB15441D66DA9300EDDDE1 /* ScalarTest.cpp in Sources */,
         23CB15451D66DA9300EDDDE1 /* SocketAddressTest.cpp in Sources */,
         9A3D43DD1F3151C400EB767C /* TimerTest.cpp in Sources */,
         23CB15461D66DA9300EDDDE1 /* GDBRemoteTestUtils.cpp in Sources */,
         23E2E5271D903782006F38BB /* MinidumpParserTest.cpp in Sources */,

unittests/Utility/VASprintfTest.cpp

 //===-- VASprintfTest.cpp ---------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "lldb/Utility/VASPrintf.h"
 #include "llvm/ADT/SmallString.h"
 
 #include "gtest/gtest.h"
 
 #include <locale.h>
 
+#if defined (_WIN32)
+#define TEST_ENCODING ".932"  // On Windows, test codepage 932
+#else
+#define TEST_ENCODING "C"     // ...otherwise, any widely available uni-byte LC
+#endif
+
 using namespace lldb_private;
 using namespace llvm;
 
 static bool Sprintf(llvm::SmallVectorImpl<char> &Buffer, const char *Fmt, ...) {
   va_list args;
   va_start(args, Fmt);
   bool Result = VASprintf(Buffer, Fmt, args);
   va_end(args);
TEST(VASprintfTest, BufferResize) {
   EXPECT_STREQ(TestStr.c_str(), SmallBuffer.c_str());
   EXPECT_EQ(TestStr.size(), SmallBuffer.size());
 }
 
 TEST(VASprintfTest, EncodingError) {
   // Save the current locale first.
   std::string Current(::setlocale(LC_ALL, nullptr));
 
-  setlocale(LC_ALL, ".932");
+  // Ensure tested locale is successfully set
+  ASSERT_TRUE(setlocale(LC_ALL, TEST_ENCODING));
 
   wchar_t Invalid[2];
   Invalid[0] = 0x100;
   Invalid[1] = 0;
   llvm::SmallString<32> Buffer;
   EXPECT_FALSE(Sprintf(Buffer, "%ls", Invalid));
   EXPECT_EQ("<Encoding error>", Buffer);
 
-  setlocale(LC_ALL, Current.c_str());
+  // Ensure we've restored the original locale once tested
+  ASSERT_TRUE(setlocale(LC_ALL, Current.c_str()));
 }