Page MenuHomePhabricator

penryu (Tim Hammerquist)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2016, 2:00 PM (166 w, 5 d)

Recent Activity

Jan 4 2018

penryu committed rL321840: remove unreferenced footnotes.
remove unreferenced footnotes
Jan 4 2018, 4:26 PM
penryu committed rL321839: fix invalid footnote syntax.
fix invalid footnote syntax
Jan 4 2018, 4:26 PM

Dec 11 2017

penryu committed rL320453: Add debugsign and test suite.
Add debugsign and test suite
Dec 11 2017, 6:37 PM

Oct 3 2017

penryu committed rL314849: cmake + xcode: prevent gtests from using includes from project root.
cmake + xcode: prevent gtests from using includes from project root
Oct 3 2017, 2:22 PM
penryu closed D36598: cmake + xcode: prevent gtests from using includes from project root by committing rL314849: cmake + xcode: prevent gtests from using includes from project root.
Oct 3 2017, 2:22 PM

Aug 21 2017

penryu updated the diff for D36598: cmake + xcode: prevent gtests from using includes from project root.

This patch limits the above include dir to unittests/, and renamed some headers to reduce ambiguity about their purpose, as suggested by beanz.

Aug 21 2017, 1:37 PM

Aug 11 2017

penryu added a comment to D36598: cmake + xcode: prevent gtests from using includes from project root.

Note that these changes were tested on Darwin with both cmake and xcode.

Aug 11 2017, 3:12 PM
penryu retitled D36598: cmake + xcode: prevent gtests from using includes from project root from Prevent gtests from using includes from project root to cmake + xcode: prevent gtests from using includes from project root.
Aug 11 2017, 1:18 PM

Aug 10 2017

penryu created D36598: cmake + xcode: prevent gtests from using includes from project root.
Aug 10 2017, 4:43 PM

Aug 9 2017

penryu committed rL310512: Add remainder of unittests to Xcode project.
Add remainder of unittests to Xcode project
Aug 9 2017, 12:46 PM
penryu added a comment to D36496: Fix VASprintfTest.cpp for Darwin, add checks.

Committed revision 310499.
Closing revision D36496 'Fix VASprintfTest.cpp for Darwin, add checks'...

Aug 9 2017, 10:28 AM
penryu committed rL310499: Fix VASprintfTest.cpp for Darwin, add checks.
Fix VASprintfTest.cpp for Darwin, add checks
Aug 9 2017, 10:28 AM
penryu closed D36496: Fix VASprintfTest.cpp for Darwin, add checks.
Aug 9 2017, 10:27 AM

Aug 8 2017

penryu added a comment to D36496: Fix VASprintfTest.cpp for Darwin, add checks.

I'd prototyped this as simply prepending "DISABLED_" for non-Windows, but as this was designed as a temporary measure, I decided to ensure the same behavior was tested on Windows, and similar/equivalent behavior tested on other platforms.

Aug 8 2017, 4:36 PM
penryu created D36496: Fix VASprintfTest.cpp for Darwin, add checks.
Aug 8 2017, 4:31 PM
penryu added a comment to D36485: Add existing unit tests to Xcode project.

Committing 'D36485: Add existing unit tests to Xcode project'...
Sending lldb.xcodeproj/project.pbxproj
Transmitting file data .done
Committing transaction...
Committed revision 310417.
Closing revision D36485 'Add existing unit tests to Xcode project'...
Done.

Aug 8 2017, 2:00 PM
penryu committed rL310417: Add existing unit tests to Xcode project.
Add existing unit tests to Xcode project
Aug 8 2017, 2:00 PM
penryu closed D36485: Add existing unit tests to Xcode project.
Aug 8 2017, 2:00 PM
penryu edited reviewers for D36485: Add existing unit tests to Xcode project, added: spyffe, jingham; removed: zturner, labath.

This is really an Xcode-only change.

Aug 8 2017, 1:39 PM
penryu added a comment to D36485: Add existing unit tests to Xcode project.

Note that VASprintfTest.cpp is added to the xcodeproj but not added to the lldb-gtest-build target _YET_. It needs some work before I can enable it.

Aug 8 2017, 1:30 PM
penryu created D36485: Add existing unit tests to Xcode project.
Aug 8 2017, 1:30 PM

Jul 19 2017

penryu committed rL308521: make LLDB test archs configurable in the environment.
make LLDB test archs configurable in the environment
Jul 19 2017, 1:44 PM

Jul 18 2017

penryu committed rL308393: cmake build needs to run tests AND collect results.
cmake build needs to run tests AND collect results
Jul 18 2017, 4:45 PM
penryu committed rL308381: Display arguments passed to dotest.py.
Display arguments passed to dotest.py
Jul 18 2017, 2:32 PM

Jul 11 2017

penryu committed rL307712: switch on enum should be exhaustive and warning-free.
switch on enum should be exhaustive and warning-free
Jul 11 2017, 2:06 PM
penryu closed D35036: switch on enum should be exhaustive and warning-free.
Jul 11 2017, 2:06 PM

Jul 10 2017

penryu requested review of D35036: switch on enum should be exhaustive and warning-free.

I need to learn more about the number formatters before I make more significant changes than those below. As written currently, it leaves the logic intact and resolves the warning. One step closer to warning-free LLDB!

Jul 10 2017, 5:20 PM

Jul 6 2017

penryu committed rL307335: Fix Xcode project file for gtest schemes..
Fix Xcode project file for gtest schemes.
Jul 6 2017, 4:26 PM

Jul 5 2017

penryu planned changes to D35036: switch on enum should be exhaustive and warning-free.
Jul 5 2017, 10:32 PM
penryu added a comment to D35036: switch on enum should be exhaustive and warning-free.

I'll be honest, my prefer solution involves an inlined function (uint64_t -> TypeCodes) that eliminates the cast from the NSNumberSummaryProvider() method altogether. This way we can handle any dirty mappings from raw memory directory to the enum within the one function, and take advantage of the compiler's exhaustiveness check to ensure we're covering our bases.

Jul 5 2017, 10:31 PM
penryu committed rL307228: add googlemock include dir to lldb-gtest Xcode target.
add googlemock include dir to lldb-gtest Xcode target
Jul 5 2017, 5:09 PM
penryu updated the summary of D35036: switch on enum should be exhaustive and warning-free.
Jul 5 2017, 3:37 PM
penryu created D35036: switch on enum should be exhaustive and warning-free.
Jul 5 2017, 3:28 PM

Jun 29 2017

penryu committed rL306765: Fix some type-based warnings.
Fix some type-based warnings
Jun 29 2017, 4:34 PM

Jun 12 2017

penryu committed rL305225: Add EOL at EOF to appease source utils like unifdef.
Add EOL at EOF to appease source utils like unifdef
Jun 12 2017, 1:09 PM

Apr 28 2017

penryu committed rL301686: Public headers need to be public..
Public headers need to be public.
Apr 28 2017, 2:16 PM
penryu abandoned D32548: Xfail data formatter test cases.

Lang's change in https://reviews.llvm.org/D32554 makes these unnecessary.

Apr 28 2017, 1:44 PM
penryu committed rL301664: Add remaining SBTrace headers to LLDB framework.
Add remaining SBTrace headers to LLDB framework
Apr 28 2017, 11:24 AM

Apr 27 2017

penryu committed rL301600: integrate SBTrace changes into Xcode project.
integrate SBTrace changes into Xcode project
Apr 27 2017, 4:22 PM

Apr 26 2017

penryu added reviewers for D32548: Xfail data formatter test cases: jingham, jasonmolenda.
Apr 26 2017, 2:30 PM
penryu updated subscribers of D32548: Xfail data formatter test cases.
Apr 26 2017, 2:25 PM
penryu updated subscribers of D32548: Xfail data formatter test cases.
Apr 26 2017, 11:51 AM
penryu updated the diff for D32548: Xfail data formatter test cases.

Update xfail reason to Phabricator ID.

Apr 26 2017, 11:50 AM
penryu added a comment to D32548: Xfail data formatter test cases.

Note that I have not addressed the failure of python_api/exprpath_synthetic/TestExprPathSynthetic.py, as the implementation of the test is alien to me.

Apr 26 2017, 11:46 AM
penryu created D32548: Xfail data formatter test cases.
Apr 26 2017, 10:56 AM
penryu closed D26486: Add timestamp to build.py footer.

Committed r286492

Apr 26 2017, 10:52 AM · Restricted Project

Mar 31 2017

penryu committed rL299261: add more RegisterContext files to xcode project.
add more RegisterContext files to xcode project
Mar 31 2017, 2:16 PM

Mar 30 2017

penryu committed rL299116: add NetBSD files to Xcode project to resolve failure from r299109.
add NetBSD files to Xcode project to resolve failure from r299109
Mar 30 2017, 2:40 PM

Mar 29 2017

penryu committed rL299039: revert changes to build.py in lldb.
revert changes to build.py in lldb
Mar 29 2017, 5:14 PM

Mar 24 2017

penryu committed rL298732: log all lldb testcases, regardless of status.
log all lldb testcases, regardless of status
Mar 24 2017, 1:57 PM

Mar 23 2017

penryu committed rL298674: Execute dotest suite single-threaded.
Execute dotest suite single-threaded
Mar 23 2017, 6:11 PM

Mar 22 2017

penryu committed rL298547: Merge r298536 changes to Xcode.
Merge r298536 changes to Xcode
Mar 22 2017, 1:34 PM
penryu committed rL298517: Merge changes from r298466 into Xcode project.
Merge changes from r298466 into Xcode project
Mar 22 2017, 9:59 AM

Mar 21 2017

penryu committed rL298451: Mirror CMake changes from r298412 to Xcode project.
Mirror CMake changes from r298412 to Xcode project
Mar 21 2017, 3:20 PM

Mar 17 2017

penryu committed rL298123: allow for specification of compiler/lldb executables basename.
allow for specification of compiler/lldb executables basename
Mar 17 2017, 2:13 PM
penryu committed rL298111: executables should be validated before spawning subprocesses.
executables should be validated before spawning subprocesses
Mar 17 2017, 11:23 AM

Mar 10 2017

penryu committed rL297538: fix xunit attribute parsing.
fix xunit attribute parsing
Mar 10 2017, 5:10 PM

Mar 7 2017

penryu committed rL297228: fix format specifier warnings.
fix format specifier warnings
Mar 7 2017, 1:48 PM

Mar 3 2017

penryu committed rL296925: Fix Darwin failures introduced in r296909.
Fix Darwin failures introduced in r296909
Mar 3 2017, 3:29 PM

Feb 27 2017

penryu committed rL296406: update pbxproj to match cmake config, broken in r296335.
update pbxproj to match cmake config, broken in r296335
Feb 27 2017, 3:08 PM

Nov 10 2016

penryu committed rL286492: Add timestamp to build.py footer.
Add timestamp to build.py footer
Nov 10 2016, 11:37 AM
penryu accepted D26486: Add timestamp to build.py footer.

OTS reviewed by medwards

Nov 10 2016, 11:36 AM · Restricted Project
penryu added a comment to D26486: Add timestamp to build.py footer.
Nov 10 2016, 11:36 AM · Restricted Project
penryu removed a reviewer for D26486: Add timestamp to build.py footer: beanz.
Nov 10 2016, 11:33 AM · Restricted Project

Nov 9 2016

penryu retitled D26486: Add timestamp to build.py footer from Add timestamp build.py footer to Add timestamp to build.py footer.
Nov 9 2016, 5:18 PM · Restricted Project
penryu retitled D26486: Add timestamp to build.py footer from to Add timestamp build.py footer.
Nov 9 2016, 4:55 PM · Restricted Project

Nov 8 2016

penryu closed D26426: Remove unnecessary libcxx/compiler-rt components from Green Dragon build process.

r286311

Nov 8 2016, 3:48 PM · Unknown Object (Project)
penryu committed rL286311: Remove libcxx/compiler-rt from build process.
Remove libcxx/compiler-rt from build process
Nov 8 2016, 3:39 PM
penryu added a comment to D26426: Remove unnecessary libcxx/compiler-rt components from Green Dragon build process.

Sending zorg/jenkins/build.py
Transmitting file data .done
Committing transaction...
Committed revision 286311.

Nov 8 2016, 3:39 PM · Unknown Object (Project)
penryu retitled D26426: Remove unnecessary libcxx/compiler-rt components from Green Dragon build process from to Remove unnecessary libcxx/compiler-rt components from Green Dragon build process.
Nov 8 2016, 2:49 PM · Unknown Object (Project)

Oct 4 2016

penryu committed rL283082: Fix regex in lldb lit test TestCallStopAndContinue.
Fix regex in lldb lit test TestCallStopAndContinue
Oct 4 2016, 1:04 AM

Oct 2 2016

penryu added a comment to D25167: Fix regex in lldb lit test TestCallStopAndContinue.

r283082

Oct 2 2016, 6:12 PM · Unknown Object (Project)
penryu retitled D25167: Fix regex in lldb lit test TestCallStopAndContinue from Patch lldb lit test TestCallStopAndContinue to Fix regex in lldb lit test TestCallStopAndContinue.
Oct 2 2016, 4:54 PM · Unknown Object (Project)
penryu retitled D25167: Fix regex in lldb lit test TestCallStopAndContinue from to Patch lldb lit test TestCallStopAndContinue.
Oct 2 2016, 4:36 PM · Unknown Object (Project)

Sep 28 2016

penryu added a comment to D24992: build.py should run lldb python test suite against both x86_64 and i386 inferiors.

Commited in r282623

Sep 28 2016, 1:03 PM · Unknown Object (Project)
penryu committed rL282623: run python tests against i386 and x86_64 inferiors.
run python tests against i386 and x86_64 inferiors
Sep 28 2016, 1:02 PM

Sep 27 2016

penryu updated D24992: build.py should run lldb python test suite against both x86_64 and i386 inferiors.
Sep 27 2016, 4:12 PM · Unknown Object (Project)
penryu retitled D24992: build.py should run lldb python test suite against both x86_64 and i386 inferiors from to build.py should run lldb python test suite against both x86_64 and i386 inferiors.
Sep 27 2016, 4:11 PM · Unknown Object (Project)

Sep 15 2016

penryu updated subscribers of D24591: [LIT] First pass of LLDB LIT support.
Sep 15 2016, 11:05 AM