[clang-tidy] Fix another crash in make-unique check.

[hokein]

Summary

The crash happens when calling reset method without any preceding
operation like "->" or ".", this could happen in a subclass of the
"std::unique_ptr".

[alexfh]

Thank you for the fix!
Looks good!

test/clang-tidy/modernize-make-unique.cpp

419 ↗

(On Diff #110152)

I suspected folks were doing weird stuff to cause this crash ;]

clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPtrCheck.cpp

SourceLocation ExprEnd =
       Lexer::getLocForEndOfToken(Expr->getLocEnd(), 0, SM, getLangOpts());
 
   bool InMacro = ExprStart.isMacroID();
 
   if (InMacro && IgnoreMacros) {
     return;
   }
 
+  // There are some cases where we don't have operator ("." or "->") of the
+  // "reset" expression, e.g. call "reset()" method directly in the subclass of
+  // "std::unique_ptr<>". We skip these cases.
+  if (OperatorLoc.isInvalid()) {
+    return;
+  }
+
   auto Diag = diag(ResetCallStart, "use %0 instead")
               << MakeSmartPtrFunctionName;
 
   // Disable the fix in macros.
   if (InMacro) {
     return;
   }
 

clang-tools-extra/trunk/test/clang-tidy/modernize-make-unique.cpp

 void g2(std::unique_ptr<Foo> *t) {
   DEFINE(auto p = std::unique_ptr<Foo>(new Foo); t->reset(new Foo););
 }
 void macro() {
   std::unique_ptr<Foo> *t;
   g2<bar::Bar>(t);
 }
 #undef DEFINE
+
+class UniqueFoo : public std::unique_ptr<Foo> {
+ public:
+  void foo() {
+    reset(new Foo);
+    this->reset(new Foo);
+    // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: use std::make_unique instead
+    // CHECK-FIXES: *this = std::make_unique<Foo>();
+    (*this).reset(new Foo);
+    // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::make_unique instead
+    // CHECK-FIXES: (*this) = std::make_unique<Foo>();
+  }
+};