private_typeinfo: propagate static flags in vmi search_above_dst method

[rprichard]

Summary

Propagate the found_our_static_ptr and found_any_static_type flags from __vmi_class_type_info::search_above_dst to its caller.

Fixes PR33425 and PR33487

[rprichard]

See https://reviews.llvm.org/D36449 for a set of regression tests.

[EricWF]

Could you please include the tests for this change in this review?

[rprichard]

Consolidate the regression test with the bugfix.

[rprichard]

Use arcanist and see if context shows properly on Phabricator.

[EricWF]

Sorry for the delay. This LGTM.

[EricWF]

Committed in r332763.

src/private_typeinfo.cpp

else
         //    3.  We can prove that there is no public path to (static_ptr, static_type)
         //        above here.
         const Iter e = __base_info + __base_count;
         Iter p = __base_info;
         // Zero out found flags
         info->found_our_static_ptr = false;
         info->found_any_static_type = false;
         p->search_above_dst(info, dst_ptr, current_ptr, path_below, use_strcmp);
+        found_our_static_ptr |= info->found_our_static_ptr;
+        found_any_static_type |= info->found_any_static_type;
         if (++p < e)
         {
             do
             {
                 if (info->search_done)
                     break;
                 if (info->found_our_static_ptr)
                 {
else
                     //    then stop looking.
                     if (!(__flags & __non_diamond_repeat_mask))
                         break;
                 }
                 // Zero out found flags
                 info->found_our_static_ptr = false;
                 info->found_any_static_type = false;
                 p->search_above_dst(info, dst_ptr, current_ptr, path_below, use_strcmp);
+                found_our_static_ptr |= info->found_our_static_ptr;
+                found_any_static_type |= info->found_any_static_type;
             } while (++p < e);
         }
         // Restore flags
         info->found_our_static_ptr = found_our_static_ptr;
         info->found_any_static_type = found_any_static_type;
     }
 }