Page MenuHomePhabricator

[LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints
ClosedPublic

Authored by coby on Aug 6 2017, 2:29 AM.

Details

Summary

This patch is intended to enable the use of basic double letter constraints used in GCC extended inline asm {Yi Y2 Yz Y0 Ym Yt}.
Supersedes D35204
Clang counterpart: D36371

Diff Detail

Repository
rL LLVM

Event Timeline

coby created this revision.Aug 6 2017, 2:29 AM
coby edited the summary of this revision. (Show Details)Aug 6 2017, 2:30 AM
rnk added inline comments.Aug 14 2017, 2:02 PM
lib/Target/X86/X86ISelLowering.cpp
36073

You need to insert LLVM_FALLTHROUGH; after each of these if / return cases if you actually want to fall through and to satisfy -Wimplicit-fallthrough. Consider recompiling just this file with the warning enabled.

36087

This is equivalent to break.

coby updated this revision to Diff 111884.EditedAug 20 2017, 7:11 AM

Addreseed @rnk 's comments (thanks) + added some forgotten checks

rnk accepted this revision.Aug 23 2017, 1:44 PM

lgtm

This revision is now accepted and ready to land.Aug 23 2017, 1:44 PM