[zorg] Remove test_polly_format step from Polly buildbot

[pzheng]

Summary

The test_polly_format does "make polly-check-format" which is already covered by
the "make check-polly" step.

[grosser]

LGTM

buildbot/osuosl/master/config/builders.py

return [
         {'name': "polly-arm-linux",
          'slavenames': ["hexagon-build-02", "hexagon-build-03"],
          'builddir': "polly-arm-linux",
          'factory': PollyBuilder.getPollyBuildFactory(
                 clean=True,
                 install=True,
                 make='ninja',
                 jobs=16,
-                checkFormat=False,
                 extraCmakeArgs=["-G", "Ninja",
                                 "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
                                 "-DLLVM_DEFAULT_TARGET_TRIPLE=arm-linux-gnueabi",
                                 "-DLLVM_TARGET_ARCH=arm-linux-gnueabi",
                                 "-DLLVM_ENABLE_ASSERTIONS=True",
                                 "-DCMAKE_C_COMPILER:FILEPATH=/local/clang+llvm-3.7.1-x86_64-linux-gnu-ubuntu-14.04/bin/clang",
                                 "-DCMAKE_CXX_COMPILER:FILEPATH=/local/clang+llvm-3.7.1-x86_64-linux-gnu-ubuntu-14.04/bin/clang++"])}
        ]

zorg/buildbot/builders/AOSPBuilder.py

def getAOSPBuildFactory(
     clang_dir = target_clang
 
     # Build Clang for AOSP target build
     if build_clang:
         f = PollyBuilder.getPollyBuildFactory(clean=True,
                                               install=True,
                                               make='ninja',
                                               jobs=jobs,
-                                              checkFormat=False,
                                               extraCmakeArgs=extra_cmake_args)
         clang_dir = 'llvm.inst/bin'
 
     # Restore AOSP repo to a clean state
     if clean:
         f.addStep(ShellCommand(name="clean-repo",
                                command=['repo', 'forall', '-c',
                                         'git reset --hard; git clean -fdx'],

zorg/buildbot/builders/PollyBuilder.py

 import os
 
 import buildbot
 import buildbot.process.factory
 from buildbot.steps.source import SVN, Git
 from buildbot.steps.shell import Configure, ShellCommand
 from buildbot.process.properties import WithProperties
 
 from zorg.buildbot.builders import LNTBuilder
 from zorg.buildbot.builders import ClangBuilder
 
 def getPollyBuildFactory(
     clean=False,
     install=False,
     make='make',
     jobs=None,
-    checkFormat=True,
     extraCmakeArgs=[]):
     llvm_srcdir = "llvm.src"
     llvm_objdir = "llvm.obj"
     llvm_instdir = "llvm.inst"
     polly_srcdir = '%s/tools/polly' % llvm_srcdir
     clang_srcdir = '%s/tools/clang' % llvm_srcdir
     jobs_cmd = []
     if jobs is not None:
         jobs_cmd = ["-j"+str(jobs)]
     build_cmd = [make] + jobs_cmd
     install_cmd = [make, 'install'] + jobs_cmd
     check_cmd = [make, 'check-polly'] + jobs_cmd
-    check_format_cmd = [make, 'polly-check-format'] + jobs_cmd
     cmake_install = []
     if install:
         cmake_install = ["-DCMAKE_INSTALL_PREFIX=../%s" % llvm_instdir]
 
     f = buildbot.process.factory.BuildFactory()
     # Determine the build directory.
     f.addStep(buildbot.steps.shell.SetProperty(name="get_builddir",
                                                command=["pwd"],
if install:
                                command=install_cmd,
                                haltOnFailure=False,
                                description=["install"],
                                workdir=llvm_objdir))
 
     # Test Polly
     f.addStep(ShellCommand(name="test_polly",
                            command=check_cmd,
-                           haltOnFailure=True,
+                           haltOnFailure=False,
                            description=["test polly"],
                            workdir=llvm_objdir))
 
-    # Check formatting
-    if checkFormat:
-        f.addStep(ShellCommand(name="test_polly_format",
-                               command=check_format_cmd,
-                               haltOnFailure=False,
-                               description=["check formatting"],
-                               workdir=llvm_objdir))
     return f
 
 def AddExternalPollyBuildFactory(f, llvm_installdir, build_type = "Release"):
     polly_srcdir = 'polly.src'
     polly_objdir = 'polly.obj'
     polly_installdir = 'polly.install'
 
     # Determine the build directory.