Page MenuHomePhabricator

AMDGPU: IMPLICIT_DEFs do not contribute to wait states
ClosedPublic

Authored by nhaehnle on Aug 1 2017, 3:04 PM.

Details

Summary

This fixes a bug that was exposed on gfx9 in various
GL45-CTS.shaders.loops.*_iterations.select_iteration_count_fragment tests,
e.g. GL45-CTS.shaders.loops.do_while_uniform_iterations.select_iteration_count_fragment

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle created this revision.Aug 1 2017, 3:04 PM
arsenm accepted this revision.Aug 1 2017, 3:11 PM
arsenm added inline comments.
lib/Target/AMDGPU/GCNHazardRecognizer.cpp
227 ↗(On Diff #109232)

While you're here, this should probably also handle DBG_VALUE too

This revision is now accepted and ready to land.Aug 1 2017, 3:11 PM

Shouldn't the scheduler be skipping over debug instructions/implicit_defs?

This revision was automatically updated to reflect the committed changes.