The same adjustment is already done for the entry point in Writer.cpp and for relocations that point to executable code in Chunks.cpp.
Details
Diff Detail
Event Timeline
Does link actually set the ISA selection bit on the EAT entries? I don't remember that behaviour from it and I dont have it on hand to check.
COFF/DLL.cpp | ||
---|---|---|
331 | Don't use +1. If the ISA selection bit is set, then you will have erased it. |
Yes, I checked with MS link.exe and this matches what it does.
COFF/DLL.cpp | ||
---|---|---|
331 | Ok, will change into | 1 instead. |
Updated to use | 1 instead of + 1 for setting the bit, renamed the variable from Offset to Bit accordingly.
test/COFF/Inputs/export-armnt.yaml | ||
---|---|---|
1 | Move the contents of this file to test/COFF/export-armnt.test to remove this file. Usually, when there's only one input file, you can write it in the test file itself. |
Don't use +1. If the ISA selection bit is set, then you will have erased it.