Tested that a DLL+implib created with LLD seems to load properly. What would be a suitable location for a testcase for this? Some sort of higher level test in LLD?
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
That doesn't actually test this codepath, that's already handled within lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp, where VK_COFF_IMGREL32 is mapped to COFF::IMAGE_REL_ARM64_ADDR32NB. The only place where this getImgRelRelocation function is used is within COFFImportFile.cpp, in the createImportDescriptor function.
Comment Actions
Yes, I'd like to. In the original comment, I asked for suggestions on where/how to add such a test. Are there any tool entry points within llvm that actually use this functionality? Maybe llvm-dlltool; are there any other? It'd be easy to test this from within lld though.
Comment Actions
The file used to be part of lld, so I think this is tested by some test file in lld. Can you add a new test if there's such file?