This is an archive of the discontinued LLVM Phabricator instance.

Differential D35543

[AArch64] Update a comment in a test
ClosedPublic

Authored by mstorsjo on Jul 18 2017, 4:00 AM.

Download Raw Diff

Details

Reviewers

t.p.northover

Commits

rG1913360a168b: [AArch64] Update a comment in a test
rL309016: [AArch64] Update a comment in a test

Summary

The comment ended up outdated when the test was rewritten in SVN r192281.

Diff Detail

Repository: rL LLVM

Event Timeline

mstorsjo created this revision.Jul 18 2017, 4:00 AM

Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. · View Herald TranscriptJul 18 2017, 4:00 AM

Ping, this should be rather trivial.

Go for it.

This revision is now accepted and ready to land.Jul 25 2017, 7:18 AM

Closed by commit rL309016: [AArch64] Update a comment in a test (authored by mstorsjo). · Explain WhyJul 25 2017, 12:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

test/

MC/

AArch64/

adrp-relocation.s

9 lines

Diff 108141

llvm/trunk/test/MC/AArch64/adrp-relocation.s

	// RUN: llvm-mc -triple=aarch64-linux-gnu -filetype=obj -o - %s\| llvm-readobj -r - \| FileCheck %s			// RUN: llvm-mc -triple=aarch64-linux-gnu -filetype=obj -o - %s\| llvm-readobj -r - \| FileCheck %s
	// RUN: llvm-mc -target-abi=ilp32 -triple=aarch64-linux-gnu -filetype=obj \			// RUN: llvm-mc -target-abi=ilp32 -triple=aarch64-linux-gnu -filetype=obj \
	// RUN: -o - %s\| llvm-readobj -r - \| FileCheck -check-prefix=CHECK-ILP32 %s			// RUN: -o - %s\| llvm-readobj -r - \| FileCheck -check-prefix=CHECK-ILP32 %s
	.text			.text
	// These should produce an ADRP/ADD pair to calculate the address of			// This tests that LLVM doesn't think it can deal with the relocation on the ADRP
	// testfn. The important point is that LLVM shouldn't think it can deal with the			// itself (even though it knows everything about the relative offsets of sym and
	// relocation on the ADRP itself (even though it knows everything about the			// the adrp instruction) because its value depends on where this object file's
	// relative offsets of testfn and foo) because its value depends on where this			// .text section gets relocated in memory.
	// object file's .text section gets relocated in memory.
	adrp x0, sym			adrp x0, sym
	adrp x0, :got:sym			adrp x0, :got:sym
	adrp x0, :gottprel:sym			adrp x0, :gottprel:sym
	adrp x0, :tlsdesc:sym			adrp x0, :tlsdesc:sym

	.global sym			.global sym
	sym:			sym:
	// CHECK: R_AARCH64_ADR_PREL_PG_HI21 sym			// CHECK: R_AARCH64_ADR_PREL_PG_HI21 sym
	// CHECK: R_AARCH64_ADR_GOT_PAGE sym			// CHECK: R_AARCH64_ADR_GOT_PAGE sym
	// CHECK: R_AARCH64_TLSIE_ADR_GOTTPREL_PAGE21 sym			// CHECK: R_AARCH64_TLSIE_ADR_GOTTPREL_PAGE21 sym
	// CHECK: R_AARCH64_TLSDESC_ADR_PAGE21 sym			// CHECK: R_AARCH64_TLSDESC_ADR_PAGE21 sym
	// CHECK-ILP32: R_AARCH64_P32_ADR_PREL_PG_HI21 sym			// CHECK-ILP32: R_AARCH64_P32_ADR_PREL_PG_HI21 sym
	// CHECK-ILP32: R_AARCH64_P32_ADR_GOT_PAGE sym			// CHECK-ILP32: R_AARCH64_P32_ADR_GOT_PAGE sym
	// CHECK-ILP32: R_AARCH64_P32_TLSIE_ADR_GOTTPREL_PAGE21 sym			// CHECK-ILP32: R_AARCH64_P32_TLSIE_ADR_GOTTPREL_PAGE21 sym
	// CHECK-ILP32: R_AARCH64_P32_TLSDESC_ADR_PAGE21 sym			// CHECK-ILP32: R_AARCH64_P32_TLSDESC_ADR_PAGE21 sym