This patch generalizes IRCE to handle IV steps that are not equal to 1 or -1.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
The change generally looks good to me. I'll take a closer look tomorrow. Some minor comments inline.
lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp | ||
---|---|---|
807 ↗ | (On Diff #107045) | Pls Add a comment here that we calculate StepCI and whether the step is increasing or not (apart from identifying if AR is an IV). |
821 ↗ | (On Diff #107045) | could you pls check this assert in as NFC. |
1594 ↗ | (On Diff #107045) | NFC assert here can be checked in separately (with the above NFC assert). |
Comment Actions
Thanks Anna! I will check in these changes as NFCs once underlying patch https://reviews.llvm.org/D35302 is merged (on review currently).