This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][ARM] Fix filtering of ARM targets
ClosedPublic

Authored by iid_iunknown on Jul 12 2017, 4:27 PM.

Details

Summary

Similarly to i686, the ARM build target has multiple names, such as armhf, armv7 and so on. Currently we get duplicated symbol definitions for these targets while compiling the library. Each duplicated definition has its generic version from lib/builtins and an ARM-specialized version from lib/builtins/arm.

This patch fixes filtering for ARM to ignore the generic definitions if they have their ARM specializations.

Diff Detail

Repository
rL LLVM

Event Timeline

iid_iunknown created this revision.Jul 12 2017, 4:27 PM
compnerd accepted this revision.Aug 2 2017, 4:36 PM
This revision is now accepted and ready to land.Aug 2 2017, 4:36 PM
iid_iunknown closed this revision.Aug 10 2017, 6:28 AM
This revision was automatically updated to reflect the committed changes.

Thanks for reviewing this, Saleem!