Make shell redirection construct portable

[krytarowski]

Summary

NetBSD shell sh(1) does not support ">& /dev/null" construct.
This is bashism. The portable and POSIX solution is to use:
"> /dev/null 2>&1".

This change fixes 22 Unexpected Failures on NetBSD/amd64
for the "check-llvm" target.

Sponsored by <The NetBSD Foundation>

[joerg]

Strictly speaking, I think this comes from csh, but LGTM.

[davide]

This is good for portability but probably needs to be specified somewhere (programmer's manual?) but I'm not sure if we have a section on how to write tests.
Also, is there a netbsd bot to catch mistakes in future? [I don't see it].

[krytarowski]

Catch another usage of >&.

[krytarowski]

In D35277#805768, @davide wrote:

This is good for portability but probably needs to be specified somewhere (programmer's manual?) but I'm not sure if we have a section on how to write tests.
Also, is there a netbsd bot to catch mistakes in future? [I don't see it].

Yes, there is a bot:
http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8

At the moment it validates proper build in LLVM+Clang+LLDB, it will be extended for execution of tests in future.
There are still over 200 failures in LLVM to go, few in Clang, many in LLDB.

[rnk]

Eventually when we standardize on the lit test runner, this will not be an issue. LLVM can choose what shell syntax it wants to use without worrying about the system shell.

test/Analysis/BasicAA/unreachable-block.ll

-; RUN: opt -basicaa -aa-eval -disable-output < %s >& /dev/null
+; RUN: opt -basicaa -aa-eval -disable-output < %s > /dev/null 2>&1
 
 ; BasicAA shouldn't infinitely recurse on the use-def cycles in
 ; unreachable code.
 
 define void @func_2() nounwind {
 entry:
   unreachable
 
 bb:
   %t = select i1 undef, i32* %t, i32* undef
   %p = select i1 undef, i32* %p, i32* %p
   %q = select i1 undef, i32* undef, i32* %p
   %a = getelementptr i8, i8* %a, i32 0
   unreachable
 }

test/Assembler/2003-11-11-ImplicitRename.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 void %test() {
   %X = add int 0, 1
   %X = add int 1, 2
   ret void
 }
-

test/Assembler/2007-11-26-AttributeOverload.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @atoi(i8*) nounwind readonly
 declare i32 @atoi(i8*)

test/CodeGen/X86/GC/badreadproto.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
   %list = type { i32, %list* }
 
 ; This usage is invalid now; instead, objects must be bitcast to i8* for input
 ; to the gc intrinsics.
 declare %list* @llvm.gcread(%list*, %list**)
 
 define %list* @tl(%list* %l) gc "example" {
   %hd.ptr = getelementptr %list, %list* %l, i32 0, i32 0
   %hd = call %list* @llvm.gcread(%list* %l, %list** %hd.ptr)
   ret i32 %tmp
 }

test/CodeGen/X86/GC/badrootproto.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
   %list = type { i32, %list* }
   %meta = type opaque
 
 ; This usage is invalid now; instead, objects must be bitcast to i8* for input
 ; to the gc intrinsics.
 declare void @llvm.gcroot(%list*, %meta*)
 
 define void @root() gc "example" {
   %x.var = alloca i8*
   call void @llvm.gcroot(i8** %x.var, %meta* null)
 }

test/CodeGen/X86/GC/badwriteproto.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
   %list = type { i32, %list* }
 
 ; This usage is invalid now; instead, objects must be bitcast to i8* for input
 ; to the gc intrinsics.
 declare void @llvm.gcwrite(%list*, %list*, %list**)
 
 define %list* @cons(i32 %hd, %list* %tl) gc "example" {

test/CodeGen/X86/GC/fat.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare void @llvm.gcroot(i8**, i8*) nounwind
 
 define void @f() gc "x" {
   %st = alloca { i8*, i1 }    ; <{ i8*, i1 }*> [#uses=1]
   %st_ptr = bitcast { i8*, i1 }* %st to i8**    ; <i8**> [#uses=1]
   call void @llvm.gcroot(i8** %st_ptr, i8* null)
   ret void
 }

test/CodeGen/X86/GC/outside.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare void @llvm.gcroot(i8**, i8*)
 
 define void @f(i8* %x) {
   %root = alloca i8*
   call void @llvm.gcroot(i8** %root, i8* null)
   store i8* %x, i8** %root
   ret void
 }

test/Other/2002-01-31-CallGraph.ll

 ;  Call graph construction crash: Not handling indirect calls right
 ;
-; RUN: opt < %s -analyze -print-callgraph >& /dev/null
+; RUN: opt < %s -analyze -print-callgraph > /dev/null 2>&1
 ;
 
         %FunTy = type i32 (i32)
 
 define void @invoke(%FunTy* %x) {
         %foo = call i32 %x( i32 123 )           ; <i32> [#uses=0]
         ret void
 }
 
 

test/TableGen/UnterminatedComment.td

-// RUN: not llvm-tblgen < %s >& /dev/null
+// RUN: not llvm-tblgen < %s > /dev/null 2>&1
 
 def x;
 
 /*  /* /* */
 

test/Verifier/2004-05-21-SwitchConstantMismatch.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 
 
 int %main() {  
 start1:
   switch uint 0, label %brt0 [int 3, label %brt1  ]
 brt0:
   ret int 0
 brt1:
   ret int 0
 }
 

test/Verifier/2007-12-21-InvokeParamAttrs.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare void @foo(i8*)
 
 define void @bar() {
   invoke void @foo(i8* signext null)
       to label %r unwind label %r
 r:
   ret void
 }

test/Verifier/2008-01-11-VarargAttrs.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
   %struct = type {  }
 
 declare void @foo(...)
 
 define void @bar() {
   call void (...) @foo(%struct* sret null )
   ret void
 }

test/Verifier/2009-05-29-InvokeResult1.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @v()
 
 define i32 @f() {
 e:
   %r = invoke i32 @v()
       to label %c unwind label %u   ; <i32> [#uses=2]
 
 c:    ; preds = %e
   ret i32 %r
 
 u:    ; preds = %e
   ret i32 %r
 }

test/Verifier/2009-05-29-InvokeResult2.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @v()
 
 define i32 @g() {
 e:
   %s = invoke i32 @v()
       to label %c unwind label %u   ; <i32> [#uses=2]
 
 c:    ; preds = %e
   ret i32 %s
 
 u:    ; preds = %e
   %t = phi i32 [ %s, %e ]    ; <i32> [#uses=1]
   ret i32 %t
 }

test/Verifier/2009-05-29-InvokeResult3.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 
 declare i32 @v()
 
 define i32 @h() {
 e:
   %s = invoke i32 @v()
       to label %c unwind label %u   ; <i32> [#uses=2]
 

test/Verifier/byval-1.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 declare void @h(i32 byval %num)

test/Verifier/gcread-ptrptr.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }
 %obj = type { %meta* }
 
 declare %obj* @llvm.gcread(%obj*, %obj*)
 
 define %obj* @f() {
 entry:
   %x = call %obj* @llvm.gcread(%obj* null, %obj* null)
   ret %obj* %x
 }

test/Verifier/gcroot-alloca.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }
 %obj = type { %meta* }
 
 declare void @llvm.gcroot(%obj**, %meta*)
 
 define void @f() {
 entry:
   call void @llvm.gcroot(%obj** null, %meta* null)
   
   ret void
 }

test/Verifier/gcroot-meta.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }
 %obj = type { %meta* }
 
 declare void @llvm.gcroot(%obj**, %meta*)
 
 define void @f() {
 entry:
   %local.obj = alloca %obj*
   %local.meta = alloca %meta
   call void @llvm.gcroot(%obj** %local.obj, %meta* %local.meta)
   
   ret void
 }

test/Verifier/gcroot-ptrptr.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }
 %obj = type { %meta* }
 
 declare void @llvm.gcroot(%obj*, %meta*)
 
 define void @f() {
 entry:
   %local.obj = alloca %obj
   call void @llvm.gcroot(%obj* %local.obj, %meta* null)
   ret void
 }

test/Verifier/gcwrite-ptrptr.ll

-; RUN: not llvm-as < %s >& /dev/null
+; RUN: not llvm-as < %s > /dev/null 2>&1
 ; PR1633
 
 %meta = type { i8* }
 %obj = type { %meta* }
 
 declare void @llvm.gcwrite(%obj*, %obj*, %obj*)
 
 define void @f() {
 entry:
   call void @llvm.gcwrite(%obj* null, %obj* null, %obj* null)
   ret void
 }