This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Be consistent in generating trivial test input files
ClosedPublic

Authored by sbc100 on Jul 10 2017, 10:51 AM.

Details

Summary

For each checked in wasm file make sure the there is corresponding ll file that can be
used to regenerate it if needed.

Add test/Object/Inputs/trivial-object-test.wasm to match other formats and
add some new wasm tests in test/Object.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jul 10 2017, 10:51 AM
sbc100 updated this revision to Diff 105883.Jul 10 2017, 10:53 AM

Update expected test output

sbc100 edited the summary of this revision. (Show Details)Jul 10 2017, 10:56 AM
sbc100 added a reviewer: dschuff.
sbc100 added a subscriber: llvm-commits.

This change should ensure that that https://reviews.llvm.org/D35208 is tested

dschuff accepted this revision.Jul 10 2017, 1:20 PM
dschuff added inline comments.
test/Object/Inputs/trivial.ll
1 ↗(On Diff #105885)

This looks like it's supposed to be a RUN line but of course it's not. So maybe just put an explanatory comment before this line that says something like 'to regenerate the trivial-object.wasm file, run the following command.'

test/tools/llvm-objdump/Inputs/trivial.ll
1 ↗(On Diff #105885)

and ditto here.

This revision is now accepted and ready to land.Jul 10 2017, 1:20 PM
sbc100 updated this revision to Diff 105912.Jul 10 2017, 1:30 PM
  • add comments
test/Object/Inputs/trivial.ll
1 ↗(On Diff #105885)

Done.

This revision was automatically updated to reflect the committed changes.