This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Add a max VM address check for Darwin/AArch64
ClosedPublic

Authored by kubamracek on Jul 7 2017, 3:05 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Jul 7 2017, 3:05 PM
dvyukov accepted this revision.Jul 10 2017, 12:50 AM
This revision is now accepted and ready to land.Jul 10 2017, 12:50 AM
dvyukov added inline comments.Jul 10 2017, 12:52 AM
lib/tsan/rtl/tsan_platform_mac.cc
235 ↗(On Diff #105709)

This can provide a better error message without an unnecessary stack trace, but up to you.

if (max_vm != kHiAppMemEnd) {
  Printf("ThreadSanitizer: unsupported vm address limit %p, expect %p\n", max_vm, kHiAppMemEnd);
  Die();
}
This revision was automatically updated to reflect the committed changes.