This is an archive of the discontinued LLVM Phabricator instance.

Use internal_strncpy to copy filename in linux procmaps
ClosedPublic

Authored by fjricci on Jul 7 2017, 11:28 AM.

Reviewers

alekseyshl
glider

Commits

Summary

Cleaner than using a while loop to copy the string character by character.

Build Status

Buildable 8055
Build 8055: arc lint + arc unit

This revision is now accepted and ready to land.Jul 10 2017, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

sanitizer_common/

11 lines

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	while (IsDecimal(*current_))
current_++;		current_++;
// Qemu may lack the trailing space.		// Qemu may lack the trailing space.
// https://github.com/google/sanitizers/issues/160		// https://github.com/google/sanitizers/issues/160
// CHECK_EQ(*current_++, ' ');		// CHECK_EQ(*current_++, ' ');
// Skip spaces.		// Skip spaces.
while (current_ < next_line && *current_ == ' ')		while (current_ < next_line && *current_ == ' ')
current_++;		current_++;
// Fill in the filename.		// Fill in the filename.
uptr i = 0;		if (segment->filename) {
while (current_ < next_line) {		uptr len = Min((uptr)(next_line - current_), segment->filename_size - 1);
if (segment->filename && i < segment->filename_size - 1)		internal_strncpy(segment->filename, current_, len);
segment->filename[i++] = *current_;		segment->filename[len] = 0;
current_++;
}		}
if (segment->filename && i < segment->filename_size) segment->filename[i] = 0;
current_ = next_line + 1;		current_ = next_line + 1;
return true;		return true;
}		}

} // namespace __sanitizer		} // namespace __sanitizer

#endif // SANITIZER_LINUX		#endif // SANITIZER_LINUX