Page MenuHomePhabricator

Fix use_iterator in ARM64AddressTypePromotion
Needs ReviewPublic

Authored by weimingz on Apr 23 2014, 3:18 PM.

Details

Summary

change use_iterator to user_iterator

Diff Detail

Event Timeline

weimingz updated this revision to Diff 8782.Apr 23 2014, 3:18 PM
weimingz retitled this revision from to Fix use_iterator in ARM64AddressTypePromotion.
weimingz updated this object.
weimingz edited the test plan for this revision. (Show Details)
weimingz added reviewers: apazos, t.p.northover.

Ping?

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

weimingz updated this revision to Diff 9005.Apr 30 2014, 9:55 PM

const Instruction *Inst = dyn_cast<GetElementPtrInst>(U) looks wrong. The rest two might be OK. Can someone take a quick look? Thanks

t.p.northover edited edge metadata.May 1 2014, 7:49 AM

Hi Weiming,

Did you try to come up with a test for these? You could well be right, but it's a bit difficult to say with bare code like this.

Cheers.

Tim.

Hi Tim,

Unfortunately I have no test case yet. I spot that when I scan the code for use_iterator. We got some issues with change of Use class. The tricky thing is, sometime it just causes the optimization exit quietly, no build fail or runtime assertion.

Anyway, I'll keep an eye on it and let you know if I find out something.

Thanks,
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

apazos resigned from this revision.Feb 8 2019, 10:38 AM
apazos removed a reviewer: apazos.