This is an archive of the discontinued LLVM Phabricator instance.

[PM] Add support for sample PGO in the new pass manager (clang-side)
ClosedPublic

Authored by danielcdh on Jun 27 2017, 3:53 PM.

Event Timeline

danielcdh created this revision.Jun 27 2017, 3:53 PM
danielcdh added inline comments.Jun 27 2017, 4:00 PM
test/CodeGen/pgo-sample-thinlto-summary.c
4

This test will currently fail because PrepareForLLVM has not been passed down so that we do not know if it's in the thinlto compile phase.

Related discussion: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170626/464868.html

This patch needs to commit after that issue is fixed.

tejohnson accepted this revision.Jun 28 2017, 6:23 AM
tejohnson added a subscriber: tejohnson.

LGTM for when the dependent patches are in.

This revision is now accepted and ready to land.Jun 28 2017, 6:23 AM
chandlerc accepted this revision.Jun 29 2017, 4:17 PM

LGTM too, but no need to wait for me to land this. =D

danielcdh closed this revision.Jun 29 2017, 4:33 PM