Page MenuHomePhabricator

[GSoC] Add support for CC1 options.
ClosedPublic

Authored by yamaguchi on Jun 23 2017, 9:18 AM.

Details

Summary

Add value completion support for options which are defined in
CC1Options.td, because we only handled options in Options.td.

Event Timeline

yamaguchi created this revision.Jun 23 2017, 9:18 AM
ruiu added inline comments.Jun 23 2017, 9:39 AM
clang/include/clang/Driver/CC1Options.td
29

This doesn't seem correct, as git grep target-abi shows a lot of other values, such as -target-abi aapcs.

yamaguchi updated this revision to Diff 103740.Jun 23 2017, 9:46 AM

Update patch.
@ruiu
Yes, your right.. I've totally misunderstood this.

yamaguchi updated this revision to Diff 103742.Jun 23 2017, 9:51 AM

Fixed trivial mistake.

ruiu accepted this revision.Jun 23 2017, 9:51 AM

LGTM

This revision is now accepted and ready to land.Jun 23 2017, 9:51 AM
This revision was automatically updated to reflect the committed changes.