[sanitizers] Add dedicated script for Android tests

[alekseyshl]

zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh

20 ↗

(On Diff #103602)

Platfor -> Platform

[eugenis]

zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_android.sh

51

This builds way more than necessary.
-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64
ninja clang

[vitalybuka]

zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_android.sh

51

I copied that stuff from buildbot_cmake.h, but I don't think this is important as at this point for incremental builds it spends about 90% of time on following steps.
Currently incremental build and test (with one device) is about 25 min.

zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_android.sh

+#!/usr/bin/env bash
+
+set -x
+set -e
+set -u
+
+HERE="$(cd $(dirname $0) && pwd)"
+. ${HERE}/buildbot_functions.sh
+. ${HERE}/buildbot_android_functions.sh
+
+ROOT=`pwd`
+PLATFORM=`uname`
+export PATH="/usr/local/bin:$PATH"
+
+CHECK_LIBCXX=${CHECK_LIBCXX:-1}
+CHECK_LLD=${CHECK_LLD:-1}
+STAGE1_DIR=llvm_build0
+STAGE1_CLOBBER="llvm_build64 compiler_rt_build_android_* llvm_build_android_*"
+LLVM=$ROOT/llvm
+CMAKE_COMMON_OPTIONS="-GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_PARALLEL_LINK_JOBS=20"
+BUILD_TYPE=Release
+
+if [ "$BUILDBOT_CLOBBER" != "" ]; then
+  echo @@@BUILD_STEP clobber@@@
+  rm -rf llvm
+  rm -rf ${STAGE1_DIR}
+  rm -rf android_ndk
+  rm -rf platform-tools
+fi
+
+download_android_tools r15
+
+# Stage 1
+
+build_stage1_clang_at_revison 305968
+### From now on we use just-built Clang as a host compiler ###
+CLANG_PATH=${ROOT}/${STAGE1_DIR}/bin
+
+echo @@@BUILD_STEP update@@@
+buildbot_update
+
+CMAKE_COMMON_OPTIONS="$CMAKE_COMMON_OPTIONS -DLLVM_ENABLE_ASSERTIONS=ON"
+
+# Build self-hosted tree with fresh Clang and -Werror.
+CMAKE_OPTIONS="${CMAKE_COMMON_OPTIONS} -DLLVM_ENABLE_WERROR=ON -DCMAKE_C_COMPILER=${CLANG_PATH}/clang -DCMAKE_CXX_COMPILER=${CLANG_PATH}/clang++ -DCMAKE_C_FLAGS=-gmlt -DCMAKE_CXX_FLAGS=-gmlt"
+
+echo @@@BUILD_STEP bootstrap clang@@@
+if [ ! -d llvm_build64 ]; then
+  mkdir llvm_build64
+fi
+(cd llvm_build64 && cmake ${CMAKE_OPTIONS} -DLLVM_BUILD_EXTERNAL_COMPILER_RT=ON $LLVM && ninja) || echo @@@STEP_FAILURE@@
+
+CMAKE_COMMON_OPTIONS=-DLLVM_ENABLE_ASSERTIONS=ON
+
+build_android() {
+  CPU=$1
+  TRIPLE=$2
+  build_android_ndk $CPU
+  build_compiler_rt $CPU $TRIPLE
+  build_llvm_symbolizer $CPU $TRIPLE
+}
+
+# Testing armv7 instead of plain arm to work around
+# https://code.google.com/p/android/issues/detail?id=68779
+build_android arm armv7-linux-androideabi armeabi-v7a
+build_android x86 i686-linux-android x86
+build_android arm64 aarch64-linux-android arm64-v8a
+
+test_android arm armeabi-v7a @@@STEP_FAILURE@@@
+test_android x86 x86 @@@STEP_FAILURE@@@
+test_android arm64 arm64-v8a @@@STEP_FAILURE@@@

zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh

 #!/usr/bin/env bash
 
+function download_android_tools {
+  local VERSION=android-ndk-$1
+  local FILE_NAME=${VERSION}-linux-x86_64.zip
+  local NDK_URL=https://dl.google.com/android/repository/${FILE_NAME}
+  local NDK_DIR=android_ndk
+  if  [[ "$(cat ${NDK_DIR}/android_ndk_url)" != ${NDK_URL} ]] ; then
+    echo @@@BUILD_STEP downloading Android NDK@@@
+    [[ -d ${NDK_DIR} ]] && rm -rf ${NDK_DIR}
+    [[ -d ${VERSION} ]] && rm -rf ${VERSION}
+    [[ -f ${FILE_NAME} ]] && rm -f ${FILE_NAME}
+    wget ${NDK_URL}
+    unzip ${FILE_NAME} > /dev/null
+    mv ${VERSION} ${NDK_DIR}
+    echo ${NDK_URL} > ${NDK_DIR}/android_ndk_url
+  fi
+
+  if  [[ ! -d platform-tools ]] ; then
+    echo @@@BUILD_STEP downloading Android Platform Tools@@@
+    local FILE_NAME=platform-tools-latest-linux.zip
+    [[ -f ${FILE_NAME} ]] && rm -f ${FILE_NAME}
+    wget https://dl.google.com/android/repository/${FILE_NAME}
+    unzip ${FILE_NAME} > /dev/null
+  fi
+  export PATH=$ROOT/platform-tools/:$PATH
+}
+
+function build_android_ndk {
+    local NDK_DIR=android_ndk
+    local _arch=$1
+    if [[ ! -d $NDK_DIR/standalone-$_arch ]] ; then 
+      echo @@@BUILD_STEP building Android NDK for $_arch@@@
+      $NDK_DIR/build/tools/make_standalone_toolchain.py --api 24 --force --arch $_arch --install-dir $NDK_DIR/standalone-$_arch
+    fi
+}
+
 function build_llvm_symbolizer { # ARCH triple
     local _arch=$1
     local _triple=$2
-    
+    echo @@@BUILD_STEP build llvm-symbolizer android/$_arch@@@
+    
     rm -rf llvm_build_android_$_arch
     mkdir llvm_build_android_$_arch
     cd llvm_build_android_$_arch
 
-    local ANDROID_TOOLCHAIN=$ROOT/../../../android-ndk/standalone-$_arch
+    local ANDROID_TOOLCHAIN=$ROOT/android_ndk/standalone-$_arch
     local ANDROID_FLAGS="--target=$_triple --sysroot=$ANDROID_TOOLCHAIN/sysroot -B$ANDROID_TOOLCHAIN"
     cmake -GNinja \
         -DCMAKE_BUILD_TYPE=Release \
         -DLLVM_ENABLE_WERROR=OFF \
         -DCMAKE_C_COMPILER=$ROOT/llvm_build64/bin/clang \
         -DCMAKE_CXX_COMPILER=$ROOT/llvm_build64/bin/clang++ \
         -DCMAKE_C_FLAGS="$ANDROID_FLAGS" \
         -DCMAKE_CXX_FLAGS="$ANDROID_FLAGS" \
         -DCMAKE_EXE_LINKER_FLAGS="-pie" \
         -DCMAKE_SKIP_RPATH=ON \
-        -DANDROID=1 \
         -DLLVM_BUILD_RUNTIME=OFF \
         -DLLVM_TABLEGEN=$ROOT/llvm_build64/bin/llvm-tblgen \
         ${CMAKE_COMMON_OPTIONS} \
         $LLVM || echo @@@STEP_FAILURE@@@
     ninja llvm-symbolizer || echo @@@STEP_FAILURE@@@
 
     cd ..
 }
 
 function build_compiler_rt { # ARCH triple
     local _arch=$1
     local _triple=$2
 
-    local ANDROID_TOOLCHAIN=$ROOT/../../../android-ndk/standalone-$_arch
+    echo @@@BUILD_STEP build compiler-rt android/$_arch@@@
+
+    local ANDROID_TOOLCHAIN=$ROOT/android_ndk/standalone-$_arch
     local ANDROID_LIBRARY_OUTPUT_DIR=$(ls -d $ROOT/llvm_build64/lib/clang/* | tail -1)
     local ANDROID_EXEC_OUTPUT_DIR=$ROOT/llvm_build64/bin
     local ANDROID_FLAGS="--target=$_triple --sysroot=$ANDROID_TOOLCHAIN/sysroot -B$ANDROID_TOOLCHAIN"
 
     # Always clobber android build tree.
     # It has a hidden dependency on clang (through CXX) which is not known to
     # the build system.
     rm -rf compiler_rt_build_android_$_arch
function patch_abilist { # IN OUT
     fi
     eval $_out="'$_abilist'"
 }
 
 function test_android { # ARCH ABI STEP_FAILURE
     local _arch=$1
     local _abi=$2
     local _step_failure=$3
-    ANDROID_DEVICES=$(adb devices | grep 'device$' | awk '{print $1}')
+    ADB=adb
+    ANDROID_DEVICES=$(${ADB} devices | grep 'device$' | awk '{print $1}')
     for SERIAL in $ANDROID_DEVICES; do
-      ABILIST=$(adb -s $SERIAL shell getprop ro.product.cpu.abilist)
+      ABILIST=$(${ADB} -s $SERIAL shell getprop ro.product.cpu.abilist)
       patch_abilist $ABILIST ABILIST
       if [[ $ABILIST == *"$_abi"* ]]; then
-        BUILD_ID=$(adb -s $SERIAL shell getprop ro.build.id | tr -d '\r')
-        BUILD_FLAVOR=$(adb -s $SERIAL shell getprop ro.build.flavor | tr -d '\r')
+        BUILD_ID=$(${ADB} -s $SERIAL shell getprop ro.build.id | tr -d '\r')
+        BUILD_FLAVOR=$(${ADB} -s $SERIAL shell getprop ro.build.flavor | tr -d '\r')
         test_android_on_device "$_arch" "$SERIAL" "$BUILD_ID" "$BUILD_FLAVOR" "$_step_failure"
       fi
     done
 }
 
 function test_android_on_device { # ARCH SERIAL BUILD_ID BUILD_FLAVOR STEP_FAILURE
     local _arch=$1
     local _serial=$2
     local _build_id=$3
     local _build_flavor=$4
     local _step_failure=$5 # @@@STEP_FAILURE@@@ or @@@STEP_WARNINGS@@@
 
     DEVICE_DESCRIPTION=$_arch/$_build_flavor/$_build_id
 
-    ANDROID_SDK=$ROOT/../../../android-sdk-linux/
     SYMBOLIZER_BIN=$ROOT/llvm_build_android_$_arch/bin/llvm-symbolizer
     COMPILER_RT_BUILD_DIR=$ROOT/compiler_rt_build_android_$_arch
-    ADB=$ROOT/../../../bin/adb
+    ADB=adb
     DEVICE_ROOT=/data/local/asan_test
 
     export ANDROID_SERIAL=$_serial
     echo "Serial $_serial"
 
     echo @@@BUILD_STEP device setup [$DEVICE_DESCRIPTION]@@@
 
     $ADB wait-for-device
 
     echo "Device is up"
     $ADB devices
 
-    sleep 2
+    ($ADB disable-verity | grep "already disabled") || $ADB reboot
+    $ADB wait-for-device
 
     ADB=$ADB $ROOT/llvm_build64/bin/asan_device_setup
     sleep 2
 
     # Nexus Player does not have enough RAM to run ASan tests reliably.
     # Luckily, none of our tests need the application runtime, and killing
     # that can free several hundred megs of RAM.
     if [[ $_build_flavor == fugu* || $_build_flavor == volantis* ]]; then
       $ADB shell stop
       sleep 2
     fi
 
     # Kill leftover symbolizers. TODO: figure out what's going on.
-    $ADB shell ps | grep llvm-symbolizer | awk '{print $2}' | xargs $ADB shell kill
+    $ADB shell pkill llvm-symbolizer || true
 
     $ADB push $SYMBOLIZER_BIN /system/bin/
     $ADB shell rm -rf $DEVICE_ROOT
     $ADB shell mkdir $DEVICE_ROOT
 
     echo @@@BUILD_STEP run asan lit tests [$DEVICE_DESCRIPTION]@@@
 
     (cd $COMPILER_RT_BUILD_DIR && ninja check-asan) || echo $_step_failure

zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh

if [ "$PLATFORM" == "Darwin" ]; then
   CMAKE_COMMON_OPTIONS="${CMAKE_COMMON_OPTIONS} -DPYTHON_EXECUTABLE=/usr/bin/python"
   ENABLE_LIBCXX_FLAG="-DLLVM_ENABLE_LIBCXX=ON"
 fi
 
 if [ -e /usr/include/plugin-api.h ]; then
   CMAKE_COMMON_OPTIONS="${CMAKE_COMMON_OPTIONS} -DLLVM_BINUTILS_INCDIR=/usr/include"
 fi
 
-BUILD_ANDROID=${BUILD_ANDROID:-0}
-RUN_ANDROID=${RUN_ANDROID:-0}
-if [ $BUILD_ANDROID == 1 -o $RUN_ANDROID == 1 ] ; then
-  . ${HERE}/buildbot_android_functions.sh
-fi
 CHECK_LIBCXX=${CHECK_LIBCXX:-1}
 CHECK_SYMBOLIZER=${CHECK_SYMBOLIZER:-$CHECK_LIBCXX}
 CHECK_LLD=${CHECK_LLD:-1}
 CHECK_ASAN=0
 CHECK_UBSAN=0
 CHECK_MSAN=0
 CHECK_TSAN=0
 CHECK_LSAN=0
if [ "$CHECK_SYMBOLIZER" == "1" ]; then
     check_ninja_with_symbolizer $CHECK_DFSAN dfsan
     check_ninja_with_symbolizer $CHECK_LSAN lsan
     check_ninja_with_symbolizer $CHECK_MSAN msan
     check_ninja_with_symbolizer $CHECK_SCUDO scudo
     check_ninja_with_symbolizer $CHECK_TSAN tsan
     check_ninja_with_symbolizer $CHECK_UBSAN ubsan
   fi
 fi
-
-if [ $BUILD_ANDROID == 1 ] ; then
-    build_android() {
-      CPU=$1
-      TRIPLE=$2
-      echo @@@BUILD_STEP build compiler-rt android/$CPU@@@
-      build_compiler_rt $CPU $TRIPLE
-
-      echo @@@BUILD_STEP build llvm-symbolizer android/$CPU@@@
-      build_llvm_symbolizer $CPU $TRIPLE
-    }
-    # Testing armv7 instead of plain arm to work around
-    # https://code.google.com/p/android/issues/detail?id=68779
-    build_android arm armv7-linux-androideabi
-    build_android x86 i686-linux-android
-    build_android aarch64 aarch64-linux-android
-fi
-
-if [ $RUN_ANDROID == 1 ] ; then
-    test_android arm armeabi-v7a @@@STEP_FAILURE@@@
-    test_android x86 x86 @@@STEP_FAILURE@@@
-    test_android aarch64 arm64-v8a @@@STEP_FAILURE@@@
-fi
-

zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_selector.py

BOT_ASSIGNMENT = {
     'sanitizer-x86_64-linux-fast': bash('buildbot_fast.sh'),
     'sanitizer-x86_64-linux-autoconf': bash('buildbot_standard.sh'),
     'sanitizer-x86_64-linux-fuzzer': bash('buildbot_fuzzer.sh'),
 }
 
 BOT_ADDITIONAL_ENV = {
     'sanitizer-ppc64le-linux': { 'HAVE_NINJA': '1', 'CHECK_LIBCXX': '0', 'CHECK_LLD': '0' },
     'sanitizer-ppc64be-linux': { 'HAVE_NINJA': '1', 'CHECK_LIBCXX': '0', 'CHECK_LLD': '0' },
-    'sanitizer-x86_64-linux': { 'HAVE_NINJA' : '1', 'BUILD_ANDROID' : '1', 'RUN_ANDROID' : '1' },
+    'sanitizer-x86_64-linux': { 'HAVE_NINJA' : '1' },
     'sanitizer-x86_64-linux-bootstrap': {},
     'sanitizer-x86_64-linux-fast': {},
     'sanitizer-x86_64-linux-autoconf': {},
     'sanitizer-x86_64-linux-fuzzer': {},
 }
 
 def Main():
   builder = os.environ.get('BUILDBOT_BUILDERNAME')