Page MenuHomePhabricator

[NFC] Update to account for DiagnosticRenderer use of FullSourceLoc
ClosedPublic

Authored by peter.smith on Jun 22 2017, 7:19 AM.

Details

Summary

D31709 [NFC] Refactor DiagnosticRenderer to use FullSourceLoc was committed in r305684 and reverted in 305688 as clang-tidy and clang-query failed to build. This change updates the extra tools to use the new interface.

With this change D31709 can be recommitted

Diff Detail

Event Timeline

peter.smith created this revision.Jun 22 2017, 7:19 AM
christof edited edge metadata.Jun 22 2017, 7:43 AM

This looks good to me. But since I have never touch this code, I'll wait a bit till accepting this for others to have a say.

Added Alexander as he seems to have touched clang-tidy recently.

alexfh accepted this revision.Jun 23 2017, 6:32 AM

LG. Looks like a pretty mechanical change.

This revision is now accepted and ready to land.Jun 23 2017, 6:32 AM
This revision was automatically updated to reflect the committed changes.