This is an archive of the discontinued LLVM Phabricator instance.

Differential D34366

[AMDGPU] Add infer address spaces pass before SROA
ClosedPublic

Authored by rampitec on Jun 19 2017, 2:14 PM.

Details

Reviewers
arsenm
Commits
rG50c2f251f549: [AMDGPU] Add infer address spaces pass before SROA
rL305759: [AMDGPU] Add infer address spaces pass before SROA
Summary

It adds it for the target after inlining but before SROA where we can get most out of it.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Jun 19 2017, 2:14 PM
Herald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald TranscriptJun 19 2017, 2:14 PM
arsenm requested changes to this revision.Jun 19 2017, 3:25 PM
arsenm added inline comments.
lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
346–349

Should add a comment explaining this

test/CodeGen/AMDGPU/infer-addrpace-pipeline.ll
1

Why disable verify?

1

I'm not sure if this requires asserts for the -debug-pass to work, but it might

This revision now requires changes to proceed.Jun 19 2017, 3:25 PM
rampitec added inline comments.Jun 19 2017, 3:29 PM
test/CodeGen/AMDGPU/infer-addrpace-pipeline.ll
1

None of existing tests -debug-pass=Structure have REQUIRES: asserts.

1

-disable-verify is here to not flood the output of pass structure. There is nothing to verify there anyway.

rampitec updated this revision to Diff 103116.Jun 19 2017, 3:32 PM
rampitec edited edge metadata.
rampitec marked an inline comment as done.

Added requested comment.

arsenm accepted this revision.Jun 19 2017, 4:14 PM

LGTM

lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
349

Typo address spaces

This revision is now accepted and ready to land.Jun 19 2017, 4:14 PM
rampitec marked an inline comment as done.Jun 19 2017, 4:17 PM
Closed by commit rL305759: [AMDGPU] Add infer address spaces pass before SROA (authored by rampitec). · Explain WhyJun 19 2017, 4:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
6 lines
test/
CodeGen/
AMDGPU/
10 lines

Diff 103109

lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

Show First 20 Lines • Show All 336 Lines • ▼ Show 20 Linesvoid AMDGPUTargetMachine::adjustPassManager(PassManagerBuilder &Builder) {
Builder.addExtension( Builder.addExtension(
PassManagerBuilder::EP_EarlyAsPossible, PassManagerBuilder::EP_EarlyAsPossible,
[AMDGPUAA](const PassManagerBuilder &, legacy::PassManagerBase &PM) { [AMDGPUAA](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
if (AMDGPUAA) { if (AMDGPUAA) {
PM.add(createAMDGPUAAWrapperPass()); PM.add(createAMDGPUAAWrapperPass());
PM.add(createAMDGPUExternalAAWrapperPass()); PM.add(createAMDGPUExternalAAWrapperPass());
} }
}); });
Builder.addExtension(
PassManagerBuilder::EP_CGSCCOptimizerLate,
[](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
PM.add(createInferAddressSpacesPass());
arsenmUnsubmitted
Done
ReplyInline Actions

Should add a comment explaining this

arsenm: Should add a comment explaining this
arsenmUnsubmitted
Done
ReplyInline Actions

Typo address spaces

arsenm: Typo address spaces
});
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// R600 Target Machine (R600 -> Cayman) // R600 Target Machine (R600 -> Cayman)
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
R600TargetMachine::R600TargetMachine(const Target &T, const Triple &TT, R600TargetMachine::R600TargetMachine(const Target &T, const Triple &TT,
StringRef CPU, StringRef FS, StringRef CPU, StringRef FS,
▲ Show 20 Lines • Show All 498 Lines • Show Last 20 Lines

test/CodeGen/AMDGPU/infer-addrpace-pipeline.ll

  • This file was added.
; RUN: opt -mtriple=amdgcn--amdhsa -disable-output -disable-verify -debug-pass=Structure -O2 %s 2>&1 | FileCheck -check-prefix=GCN %s
arsenmUnsubmitted
Not Done
ReplyInline Actions

Why disable verify?

arsenm: Why disable verify?
rampitecAuthorUnsubmitted
Not Done
ReplyInline Actions

-disable-verify is here to not flood the output of pass structure. There is nothing to verify there anyway.

rampitec: -disable-verify is here to not flood the output of pass structure. There is nothing to verify…
arsenmUnsubmitted
Not Done
ReplyInline Actions

I'm not sure if this requires asserts for the -debug-pass to work, but it might

arsenm: I'm not sure if this requires asserts for the -debug-pass to work, but it might
rampitecAuthorUnsubmitted
Not Done
ReplyInline Actions

None of existing tests -debug-pass=Structure have REQUIRES: asserts.

rampitec: None of existing tests -debug-pass=Structure have REQUIRES: asserts.
; GCN: Function Integration/Inlining
; GCN: FunctionPass Manager
; GCN: Infer address spaces
; GCN: SROA
define void @empty() {
ret void
}